Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1205870 > unrolled thread
| Started by | Maxime Lorrillere <maxime.lorrillere@gmail.com> |
|---|---|
| First post | 2015-08-12 12:00 +0200 |
| Last post | 2015-08-15 04:00 +0200 |
| Articles | 5 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH 1/2] staging: lustre: fix static declarations in libcfs Maxime Lorrillere <maxime.lorrillere@gmail.com> - 2015-08-12 12:00 +0200
[PATCH 2/2] staging: lustre: fix symbol redeclared with different type in libcfs Maxime Lorrillere <maxime.lorrillere@gmail.com> - 2015-08-12 12:00 +0200
Re: [PATCH 1/2] staging: lustre: fix static declarations in libcfs Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-08-14 08:10 +0200
Re: [PATCH 1/2] staging: lustre: fix static declarations in libcfs Maxime Lorrillere <maxime.lorrillere@gmail.com> - 2015-08-14 16:10 +0200
Re: [PATCH 1/2] staging: lustre: fix static declarations in libcfs Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2015-08-15 04:00 +0200
| From | Maxime Lorrillere <maxime.lorrillere@gmail.com> |
|---|---|
| Date | 2015-08-12 12:00 +0200 |
| Subject | [PATCH 1/2] staging: lustre: fix static declarations in libcfs |
| Message-ID | <pWAZb-MN-3@gated-at.bofh.it> |
This patch fix the following sparse warnings in libcfs/linux/linux-debug.c: >>> linux-debug.c:64:6: warning: symbol 'lnet_upcall' was not declared. Should it be static? >>> linux-debug.c:65:6: warning: symbol 'lnet_debug_log_upcall' was not declared. Should it be static? Signed-off-by: Maxime Lorrillere <maxime.lorrillere@gmail.com> --- drivers/staging/lustre/lustre/libcfs/linux/linux-debug.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/lustre/lustre/libcfs/linux/linux-debug.c b/drivers/staging/lustre/lustre/libcfs/linux/linux-debug.c index 4545d54..f0331fa 100644 --- a/drivers/staging/lustre/lustre/libcfs/linux/linux-debug.c +++ b/drivers/staging/lustre/lustre/libcfs/linux/linux-debug.c @@ -61,8 +61,9 @@ #include <linux/kallsyms.h> -char lnet_upcall[1024] = "/usr/lib/lustre/lnet_upcall"; -char lnet_debug_log_upcall[1024] = "/usr/lib/lustre/lnet_debug_log_upcall"; +static char lnet_upcall[1024] = "/usr/lib/lustre/lnet_upcall"; +static char lnet_debug_log_upcall[1024] = + "/usr/lib/lustre/lnet_debug_log_upcall"; /** * Upcall function once a Lustre log has been dumped. -- 2.5.0 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Maxime Lorrillere <maxime.lorrillere@gmail.com> |
|---|---|
| Date | 2015-08-12 12:00 +0200 |
| Subject | [PATCH 2/2] staging: lustre: fix symbol redeclared with different type in libcfs |
| Message-ID | <pWAZc-MN-31@gated-at.bofh.it> |
| In reply to | #1205870 |
lbug_with_loc is declared with __attribute__((noreturn)) in libcfs_private.h
and without this attribute in linux-debug.c. This generates the following
sparse error:
>>> drivers/staging/lustre/lustre/libcfs/linux/linux-debug.c:149:6: error: symbol 'lbug_with_loc' redeclared with different type (originally declared at drivers/staging/lustre/lustre/libcfs/linux/../../../include/linux/libcfs/libcfs_private.h:82) - different modifiers
This patches removes this attribute in libcfs_private.h as it seems to me that
this optimization is not necessary.
Signed-off-by: Maxime Lorrillere <maxime.lorrillere@gmail.com>
---
drivers/staging/lustre/include/linux/libcfs/libcfs_private.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/include/linux/libcfs/libcfs_private.h b/drivers/staging/lustre/include/linux/libcfs/libcfs_private.h
index 9544860..e60b92b 100644
--- a/drivers/staging/lustre/include/linux/libcfs/libcfs_private.h
+++ b/drivers/staging/lustre/include/linux/libcfs/libcfs_private.h
@@ -79,7 +79,7 @@ do { \
#define KLASSERT(e) LASSERT(e)
-void lbug_with_loc(struct libcfs_debug_msg_data *)__attribute__((noreturn));
+void lbug_with_loc(struct libcfs_debug_msg_data *);
#define LBUG() \
do { \
--
2.5.0
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Sudip Mukherjee <sudipm.mukherjee@gmail.com> |
|---|---|
| Date | 2015-08-14 08:10 +0200 |
| Message-ID | <pXglI-1Zx-5@gated-at.bofh.it> |
| In reply to | #1205870 |
On Wed, Aug 12, 2015 at 11:51:04AM +0200, Maxime Lorrillere wrote: > This patch fix the following sparse warnings in libcfs/linux/linux-debug.c: > >>> linux-debug.c:64:6: warning: symbol 'lnet_upcall' was not declared. Should it be static? > >>> linux-debug.c:65:6: warning: symbol 'lnet_debug_log_upcall' was not declared. Should it be static? > > Signed-off-by: Maxime Lorrillere <maxime.lorrillere@gmail.com> > --- You have not build tested. WARNING: "lnet_debug_log_upcall" [drivers/staging/lustre/lustre/libcfs/libcfs.ko] undefined! WARNING: "lnet_upcall" [drivers/staging/lustre/lustre/libcfs/libcfs.ko] undefined! regards sudip -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Maxime Lorrillere <maxime.lorrillere@gmail.com> |
|---|---|
| Date | 2015-08-14 16:10 +0200 |
| Message-ID | <pXnQd-4h6-7@gated-at.bofh.it> |
| In reply to | #1207343 |
On vendredi 14 août 2015 à 11:28:35 (+0530), Sudip Mukherjee wrote > On Wed, Aug 12, 2015 at 11:51:04AM +0200, Maxime Lorrillere wrote: > > This patch fix the following sparse warnings in libcfs/linux/linux-debug.c: > > >>> linux-debug.c:64:6: warning: symbol 'lnet_upcall' was not declared. Should it be static? > > >>> linux-debug.c:65:6: warning: symbol 'lnet_debug_log_upcall' was not declared. Should it be static? > > > > Signed-off-by: Maxime Lorrillere <maxime.lorrillere@gmail.com> > > --- > You have not build tested. > > WARNING: "lnet_debug_log_upcall" [drivers/staging/lustre/lustre/libcfs/libcfs.ko] undefined! > WARNING: "lnet_upcall" [drivers/staging/lustre/lustre/libcfs/libcfs.ko] undefined! Sorry, I've only rebuild lustre separately. Patch 2/2 builds fine, should I submit it separately ? Regards, Maxime -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2015-08-15 04:00 +0200 |
| Message-ID | <pXyVk-36l-9@gated-at.bofh.it> |
| In reply to | #1207553 |
On Fri, Aug 14, 2015 at 04:00:31PM +0200, Maxime Lorrillere wrote: > On vendredi 14 août 2015 à 11:28:35 (+0530), Sudip Mukherjee wrote > > On Wed, Aug 12, 2015 at 11:51:04AM +0200, Maxime Lorrillere wrote: > > > This patch fix the following sparse warnings in libcfs/linux/linux-debug.c: > > > >>> linux-debug.c:64:6: warning: symbol 'lnet_upcall' was not declared. Should it be static? > > > >>> linux-debug.c:65:6: warning: symbol 'lnet_debug_log_upcall' was not declared. Should it be static? > > > > > > Signed-off-by: Maxime Lorrillere <maxime.lorrillere@gmail.com> > > > --- > > You have not build tested. > > > > WARNING: "lnet_debug_log_upcall" [drivers/staging/lustre/lustre/libcfs/libcfs.ko] undefined! > > WARNING: "lnet_upcall" [drivers/staging/lustre/lustre/libcfs/libcfs.ko] undefined! > > Sorry, I've only rebuild lustre separately. > > Patch 2/2 builds fine, should I submit it separately ? Yes please. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web