Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1205875

[PATCH 2/2] staging: lustre: fix symbol redeclared with different type in libcfs

Show all headers | View raw

lbug_with_loc is declared with __attribute__((noreturn)) in libcfs_private.h
and without this attribute in linux-debug.c. This generates the following
sparse error:
>>> drivers/staging/lustre/lustre/libcfs/linux/linux-debug.c:149:6: error: symbol 'lbug_with_loc' redeclared with different type (originally declared at drivers/staging/lustre/lustre/libcfs/linux/../../../include/linux/libcfs/libcfs_private.h:82) - different modifiers

This patches removes this attribute in libcfs_private.h as it seems to me that
this optimization is not necessary.

Signed-off-by: Maxime Lorrillere <maxime.lorrillere@gmail.com>
---
 drivers/staging/lustre/include/linux/libcfs/libcfs_private.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/lustre/include/linux/libcfs/libcfs_private.h b/drivers/staging/lustre/include/linux/libcfs/libcfs_private.h
index 9544860..e60b92b 100644
--- a/drivers/staging/lustre/include/linux/libcfs/libcfs_private.h
+++ b/drivers/staging/lustre/include/linux/libcfs/libcfs_private.h
@@ -79,7 +79,7 @@ do {									\
 
 #define KLASSERT(e) LASSERT(e)
 
-void lbug_with_loc(struct libcfs_debug_msg_data *)__attribute__((noreturn));
+void lbug_with_loc(struct libcfs_debug_msg_data *);
 
 #define LBUG()							  \
 do {								    \
-- 
2.5.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] staging: lustre: fix static declarations in libcfs Maxime Lorrillere <maxime.lorrillere@gmail.com> - 2015-08-12 12:00 +0200
  [PATCH 2/2] staging: lustre: fix symbol redeclared with different type in libcfs Maxime Lorrillere <maxime.lorrillere@gmail.com> - 2015-08-12 12:00 +0200
  Re: [PATCH 1/2] staging: lustre: fix static declarations in libcfs Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-08-14 08:10 +0200
    Re: [PATCH 1/2] staging: lustre: fix static declarations in libcfs Maxime Lorrillere <maxime.lorrillere@gmail.com> - 2015-08-14 16:10 +0200
      Re: [PATCH 1/2] staging: lustre: fix static declarations in libcfs Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2015-08-15 04:00 +0200

csiph-web