Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1205870

[PATCH 1/2] staging: lustre: fix static declarations in libcfs

From Maxime Lorrillere <maxime.lorrillere@gmail.com>
Newsgroups linux.kernel
Subject [PATCH 1/2] staging: lustre: fix static declarations in libcfs
Date 2015-08-12 12:00 +0200
Message-ID <pWAZb-MN-3@gated-at.bofh.it> (permalink)
Organization linux.* mail to news gateway

Show all headers | View raw


This patch fix the following sparse warnings in libcfs/linux/linux-debug.c:
>>> linux-debug.c:64:6: warning: symbol 'lnet_upcall' was not declared. Should it be static?
>>> linux-debug.c:65:6: warning: symbol 'lnet_debug_log_upcall' was not declared. Should it be static?

Signed-off-by: Maxime Lorrillere <maxime.lorrillere@gmail.com>
---
 drivers/staging/lustre/lustre/libcfs/linux/linux-debug.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/lustre/lustre/libcfs/linux/linux-debug.c b/drivers/staging/lustre/lustre/libcfs/linux/linux-debug.c
index 4545d54..f0331fa 100644
--- a/drivers/staging/lustre/lustre/libcfs/linux/linux-debug.c
+++ b/drivers/staging/lustre/lustre/libcfs/linux/linux-debug.c
@@ -61,8 +61,9 @@
 
 #include <linux/kallsyms.h>
 
-char lnet_upcall[1024] = "/usr/lib/lustre/lnet_upcall";
-char lnet_debug_log_upcall[1024] = "/usr/lib/lustre/lnet_debug_log_upcall";
+static char lnet_upcall[1024] = "/usr/lib/lustre/lnet_upcall";
+static char lnet_debug_log_upcall[1024] =
+	"/usr/lib/lustre/lnet_debug_log_upcall";
 
 /**
  * Upcall function once a Lustre log has been dumped.
-- 
2.5.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextNext in thread | Find similar | Unroll thread


Thread

[PATCH 1/2] staging: lustre: fix static declarations in libcfs Maxime Lorrillere <maxime.lorrillere@gmail.com> - 2015-08-12 12:00 +0200
  [PATCH 2/2] staging: lustre: fix symbol redeclared with different type in libcfs Maxime Lorrillere <maxime.lorrillere@gmail.com> - 2015-08-12 12:00 +0200
  Re: [PATCH 1/2] staging: lustre: fix static declarations in libcfs Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-08-14 08:10 +0200
    Re: [PATCH 1/2] staging: lustre: fix static declarations in libcfs Maxime Lorrillere <maxime.lorrillere@gmail.com> - 2015-08-14 16:10 +0200
      Re: [PATCH 1/2] staging: lustre: fix static declarations in libcfs Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2015-08-15 04:00 +0200

csiph-web