Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1186265 > unrolled thread

Applied "regulator: 88pm800: Remove owner" to the regulator tree

Started byMark Brown <broonie@kernel.org>
First post2015-07-16 23:20 +0200
Last post2015-07-17 14:00 +0200
Articles 5 — 2 participants

Back to article view | Back to linux.kernel

Contents

  Applied "regulator: 88pm800: Remove owner" to the regulator tree Mark Brown <broonie@kernel.org> - 2015-07-16 23:20 +0200
    Re: Applied "regulator: 88pm800: Remove owner" to the regulator tree Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-07-17 07:20 +0200
      Re: Applied "regulator: 88pm800: Remove owner" to the regulator tree Mark Brown <broonie@kernel.org> - 2015-07-17 11:50 +0200
        Re: Applied "regulator: 88pm800: Remove owner" to the regulator tree Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-07-17 12:00 +0200
          Re: Applied "regulator: 88pm800: Remove owner" to the regulator tree Mark Brown <broonie@kernel.org> - 2015-07-17 14:00 +0200

#1186265 — Applied "regulator: 88pm800: Remove owner" to the regulator tree

FromMark Brown <broonie@kernel.org>
Date2015-07-16 23:20 +0200
SubjectApplied "regulator: 88pm800: Remove owner" to the regulator tree
Message-ID<pMYJs-1Go-11@gated-at.bofh.it>
The patch

   regulator: 88pm800: Remove owner

has been applied to the regulator tree at

   git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git 

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

From f44ca44b14d697a047b7c1b32b29a1d9881f050f Mon Sep 17 00:00:00 2001
From: Mark Brown <broonie@kernel.org>
Date: Thu, 16 Jul 2015 22:17:32 +0100
Subject: [PATCH] regulator: 88pm800: Remove owner

Signed-off-by: Mark Brown <broonie@kernel.org>
---
 drivers/regulator/88pm800.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/regulator/88pm800.c b/drivers/regulator/88pm800.c
index e846e4c..1b3b3a1 100644
--- a/drivers/regulator/88pm800.c
+++ b/drivers/regulator/88pm800.c
@@ -103,7 +103,6 @@ struct pm800_regulators {
 		.ops			= &pm800_volt_range_ops,	\
 		.type			= REGULATOR_VOLTAGE,		\
 		.id			= PM800_ID_##vreg,		\
-		.owner			= THIS_MODULE,			\
 		.n_voltages		= n_volt,			\
 		.linear_ranges		= volt_ranges,			\
 		.n_linear_ranges	= ARRAY_SIZE(volt_ranges),	\
@@ -133,7 +132,6 @@ struct pm800_regulators {
 		.ops			= &pm800_volt_table_ops,	\
 		.type			= REGULATOR_VOLTAGE,		\
 		.id			= PM800_ID_##vreg,		\
-		.owner			= THIS_MODULE,			\
 		.n_voltages		= ARRAY_SIZE(ldo_volt_table),	\
 		.vsel_reg		= PM800_##vreg##_VOUT,		\
 		.vsel_mask		= 0x1f,				\
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1186456

FromKrzysztof Kozlowski <k.kozlowski@samsung.com>
Date2015-07-17 07:20 +0200
Message-ID<pN6dY-4dF-15@gated-at.bofh.it>
In reply to#1186265
2015-07-17 6:19 GMT+09:00 Mark Brown <broonie@kernel.org>:
> The patch
>
>    regulator: 88pm800: Remove owner
>
> has been applied to the regulator tree at
>
>    git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git
>
> All being well this means that it will be integrated into the linux-next
> tree (usually sometime in the next 24 hours) and sent to Linus during
> the next merge window (or sooner if it is a bug fix), however if
> problems are discovered then the patch may be dropped or reverted.
>
> You may get further e-mails resulting from automated or manual testing
> and review of the tree, please engage with people reporting problems and
> send followup patches addressing any issues that are reported if needed.
>
> If any updates are required or you are submitting further changes they
> should be sent as incremental updates against current git, existing
> patches will not be replaced.
>
> Please add any relevant lists and maintainers to the CCs when replying
> to this mail.
>
> Thanks,
> Mark
>
> From f44ca44b14d697a047b7c1b32b29a1d9881f050f Mon Sep 17 00:00:00 2001
> From: Mark Brown <broonie@kernel.org>
> Date: Thu, 16 Jul 2015 22:17:32 +0100
> Subject: [PATCH] regulator: 88pm800: Remove owner

Hi Mark,

I wonder why? Isn't the owner needed for module_get/module_put or am I
missing something?

Best regards,
Krzysztof

>
> Signed-off-by: Mark Brown <broonie@kernel.org>
> ---
>  drivers/regulator/88pm800.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/regulator/88pm800.c b/drivers/regulator/88pm800.c
> index e846e4c..1b3b3a1 100644
> --- a/drivers/regulator/88pm800.c
> +++ b/drivers/regulator/88pm800.c
> @@ -103,7 +103,6 @@ struct pm800_regulators {
>                 .ops                    = &pm800_volt_range_ops,        \
>                 .type                   = REGULATOR_VOLTAGE,            \
>                 .id                     = PM800_ID_##vreg,              \
> -               .owner                  = THIS_MODULE,                  \
>                 .n_voltages             = n_volt,                       \
>                 .linear_ranges          = volt_ranges,                  \
>                 .n_linear_ranges        = ARRAY_SIZE(volt_ranges),      \
> @@ -133,7 +132,6 @@ struct pm800_regulators {
>                 .ops                    = &pm800_volt_table_ops,        \
>                 .type                   = REGULATOR_VOLTAGE,            \
>                 .id                     = PM800_ID_##vreg,              \
> -               .owner                  = THIS_MODULE,                  \
>                 .n_voltages             = ARRAY_SIZE(ldo_volt_table),   \
>                 .vsel_reg               = PM800_##vreg##_VOUT,          \
>                 .vsel_mask              = 0x1f,                         \
> --
> 2.1.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1186653

FromMark Brown <broonie@kernel.org>
Date2015-07-17 11:50 +0200
Message-ID<pNarg-1FW-19@gated-at.bofh.it>
In reply to#1186456

[Multipart message — attachments visible in raw view] — view raw

On Fri, Jul 17, 2015 at 02:11:19PM +0900, Krzysztof Kozlowski wrote:

> I wonder why? Isn't the owner needed for module_get/module_put or am I
> missing something?

The driver core apparently now does this and we shouldn't be doing it
statically so we get all this code churn.  I'm not sure I understand the
win TBH.

[toc] | [prev] | [next] | [standalone]

#1186656

FromKrzysztof Kozlowski <k.kozlowski@samsung.com>
Date2015-07-17 12:00 +0200
Message-ID<pNaAV-1Rc-3@gated-at.bofh.it>
In reply to#1186653
2015-07-17 18:43 GMT+09:00 Mark Brown <broonie@kernel.org>:
> On Fri, Jul 17, 2015 at 02:11:19PM +0900, Krzysztof Kozlowski wrote:
>
>> I wonder why? Isn't the owner needed for module_get/module_put or am I
>> missing something?
>
> The driver core apparently now does this and we shouldn't be doing it
> statically so we get all this code churn.  I'm not sure I understand the
> win TBH.

If you are referring to my recent patchset it was about platform and
i2c drivers where appropriate register functions do it (e.g.
i2c_register_driver()). But regulator_register passes owner from
regulator_desc:
rdev->owner = regulator_desc->owner;
and then calls device_register(). I think the owner for regulator
device won't be set.

Best regards,
Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1186741

FromMark Brown <broonie@kernel.org>
Date2015-07-17 14:00 +0200
Message-ID<pNct4-4xC-11@gated-at.bofh.it>
In reply to#1186656

[Multipart message — attachments visible in raw view] — view raw

On Fri, Jul 17, 2015 at 06:58:32PM +0900, Krzysztof Kozlowski wrote:
> 2015-07-17 18:43 GMT+09:00 Mark Brown <broonie@kernel.org>:

> > The driver core apparently now does this and we shouldn't be doing it
> > statically so we get all this code churn.  I'm not sure I understand the
> > win TBH.

> If you are referring to my recent patchset it was about platform and
> i2c drivers where appropriate register functions do it (e.g.
> i2c_register_driver()). But regulator_register passes owner from
> regulator_desc:

It's not just your patch set, it's the latest thing in code churn.

> rdev->owner = regulator_desc->owner;
> and then calls device_register(). I think the owner for regulator
> device won't be set.

Oh, right yes.  Picked the wrong bit of code when merging a code motion
patch.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web