Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1186656

Re: Applied "regulator: 88pm800: Remove owner" to the regulator tree

Show all headers | View raw

2015-07-17 18:43 GMT+09:00 Mark Brown <broonie@kernel.org>:
> On Fri, Jul 17, 2015 at 02:11:19PM +0900, Krzysztof Kozlowski wrote:
>
>> I wonder why? Isn't the owner needed for module_get/module_put or am I
>> missing something?
>
> The driver core apparently now does this and we shouldn't be doing it
> statically so we get all this code churn.  I'm not sure I understand the
> win TBH.

If you are referring to my recent patchset it was about platform and
i2c drivers where appropriate register functions do it (e.g.
i2c_register_driver()). But regulator_register passes owner from
regulator_desc:
rdev->owner = regulator_desc->owner;
and then calls device_register(). I think the owner for regulator
device won't be set.

Best regards,
Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Applied "regulator: 88pm800: Remove owner" to the regulator tree Mark Brown <broonie@kernel.org> - 2015-07-16 23:20 +0200
  Re: Applied "regulator: 88pm800: Remove owner" to the regulator tree Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-07-17 07:20 +0200
    Re: Applied "regulator: 88pm800: Remove owner" to the regulator tree Mark Brown <broonie@kernel.org> - 2015-07-17 11:50 +0200
      Re: Applied "regulator: 88pm800: Remove owner" to the regulator tree Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-07-17 12:00 +0200
        Re: Applied "regulator: 88pm800: Remove owner" to the regulator tree Mark Brown <broonie@kernel.org> - 2015-07-17 14:00 +0200

csiph-web