Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1742673

Re: [PATCH v3 2/3] iio: accel: mma8452: Rename time step look up struct to generic name as the values are same for all the events.

Path csiph.com!fu-berlin.de!bofh.it!news.nic.it!robomod
From Jonathan Cameron <jic23@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH v3 2/3] iio: accel: mma8452: Rename time step look up struct to generic name as the values are same for all the events.
Date Sat, 30 Sep 2017 20:10:01 +0200
Message-ID <uvun7-7CT-5@gated-at.bofh.it> (permalink)
References <utz7z-5aK-3@gated-at.bofh.it> <utz7A-5aK-15@gated-at.bofh.it> <uueu6-7gi-15@gated-at.bofh.it>
Dmarc-Filter OpenDMARC Filter v1.3.2 mail.kernel.org 7A108218BD
Authentication-Results mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org
Authentication-Results mail.kernel.org; spf=none smtp.mailfrom=jic23@kernel.org
X-Mailer Claws Mail 3.15.1-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu)
MIME-Version 1.0
Content-Type text/plain; charset=US-ASCII
Content-Transfer-Encoding 8BIT
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 27
Organization linux.* mail to news gateway
X-Original-Cc Harinath Nampally <harinath922@gmail.com>, knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, gregkh@linuxfoundation.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, amsfield22@gmail.com
X-Original-Date Sat, 30 Sep 2017 19:05:11 +0100
X-Original-Message-ID <20170930190511.2832064c@archlinux>
X-Original-References <1506336008-4480-1-git-send-email-harinath922@gmail.com> <1506336008-4480-3-git-send-email-harinath922@gmail.com> <9e6c13a7d4a6cd342a650b3bd626a162@posteo.de>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1742673

Show key headers only | View raw


On Wed, 27 Sep 2017 08:51:26 +0200
Martin Kepplinger <martink@posteo.de> wrote:

> Am 25.09.2017 12:40 schrieb Harinath Nampally:
> > Improves code readability, no impact on functionality.
> > 
> > Signed-off-by: Harinath Nampally <harinath922@gmail.com>  
> 
> Please make the headline shorter and put some of it in the git commit 
> message.
> (And please just resend it "--in-reply-to" this conversation, this patch 
> nr 2 of 3)

From a patch management point of view I actually disagree with this.
I would prefer to see a clean fresh series.  Otherwise it very rapidly
gets hard to be sure that I am picking up the latest versions.

Obviously drop any patches that have already been taken.
In this case it will be a v4 series containing patches 1 and 2 only.

Thanks

Jonathan
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

Re: [PATCH v3 2/3] iio: accel: mma8452: Rename time step look up  struct to generic name as the values are same for all the events. Martin Kepplinger <martink@posteo.de> - 2017-09-27 09:00 +0200
  Re: [PATCH v3 2/3] iio: accel: mma8452: Rename time step look up  struct to generic name as the values are same for all the events. Jonathan Cameron <jic23@kernel.org> - 2017-09-30 20:10 +0200
    Re: [PATCH v3 2/3] iio: accel: mma8452: Rename time step look up  struct to generic name as the values are same for all the events. harinath Nampally <harinath922@gmail.com> - 2017-09-30 20:30 +0200

csiph-web