Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1742410
| From | Dmitry Torokhov <dmitry.torokhov@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 12/12] Input: wdt87xx_i2c - use managed devm_device_add_group |
| Date | 2017-09-30 01:50 +0200 |
| Message-ID | <uvdcD-4vC-15@gated-at.bofh.it> (permalink) |
| References | <uvay6-2Kr-17@gated-at.bofh.it> <uvaRr-36U-17@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Sat, Sep 30, 2017 at 05:38:39AM +0900, Andi Shyti wrote:
> Commit 57b8ff070f98 ("driver core: add devm_device_add_group()
> and friends") has added the the managed version for creating
> sysfs group files.
>
> Use devm_device_add_group instead of sysfs_create_group and
> remove the relative sysfs_remove_group.
>
> Signed-off-by: Andi Shyti <andi@etezian.org>
Applied, thank you.
> ---
> drivers/input/touchscreen/wdt87xx_i2c.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/input/touchscreen/wdt87xx_i2c.c b/drivers/input/touchscreen/wdt87xx_i2c.c
> index a9132603ab34..b866cc88d942 100644
> --- a/drivers/input/touchscreen/wdt87xx_i2c.c
> +++ b/drivers/input/touchscreen/wdt87xx_i2c.c
> @@ -1106,7 +1106,7 @@ static int wdt87xx_ts_probe(struct i2c_client *client,
> return error;
> }
>
> - error = sysfs_create_group(&client->dev.kobj, &wdt87xx_attr_group);
> + error = devm_device_add_group(&client->dev, &wdt87xx_attr_group);
> if (error) {
> dev_err(&client->dev, "create sysfs failed: %d\n", error);
> return error;
> @@ -1117,8 +1117,6 @@ static int wdt87xx_ts_probe(struct i2c_client *client,
>
> static int wdt87xx_ts_remove(struct i2c_client *client)
> {
> - sysfs_remove_group(&client->dev.kobj, &wdt87xx_attr_group);
> -
> return 0;
> }
>
> --
> 2.14.2
>
--
Dmitry
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 00/12] use managed devm_device_add_group for all touchscreen drivers Andi Shyti <andi@etezian.org> - 2017-09-29 23:00 +0200
[PATCH 08/12] Input: melfas_mip4 - use managed devm_device_add_group Andi Shyti <andi@etezian.org> - 2017-09-29 23:20 +0200
Re: [PATCH 08/12] Input: melfas_mip4 - use managed devm_device_add_group Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-09-30 01:40 +0200
[PATCH 02/12] Input: ad7879 - use managed devm_device_add_group Andi Shyti <andi@etezian.org> - 2017-09-29 23:20 +0200
Re: [PATCH 02/12] Input: ad7879 - use managed devm_device_add_group Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-09-30 01:50 +0200
[PATCH 04/12] Input: atmel_mxt_ts - use managed devm_device_add_group Andi Shyti <andi@etezian.org> - 2017-09-29 23:20 +0200
Re: [PATCH 04/12] Input: atmel_mxt_ts - use managed devm_device_add_group Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-09-30 01:50 +0200
[PATCH 12/12] Input: wdt87xx_i2c - use managed devm_device_add_group Andi Shyti <andi@etezian.org> - 2017-09-29 23:20 +0200
Re: [PATCH 12/12] Input: wdt87xx_i2c - use managed devm_device_add_group Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-09-30 01:50 +0200
[PATCH 05/12] Input: edt-ft5x06 - use managed devm_device_add_group Andi Shyti <andi@etezian.org> - 2017-09-30 00:00 +0200
Re: [PATCH 05/12] Input: edt-ft5x06 - use managed devm_device_add_group Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-09-30 01:50 +0200
[PATCH 06/12] Input: elants_i2c - use managed devm_device_add_group Andi Shyti <andi@etezian.org> - 2017-09-30 00:00 +0200
Re: [PATCH 06/12] Input: elants_i2c - use managed devm_device_add_group Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-09-30 01:40 +0200
[PATCH 09/12] Input: raydium_i2c_ts - use managed devm_device_add_group Andi Shyti <andi@etezian.org> - 2017-09-30 00:00 +0200
Re: [PATCH 09/12] Input: raydium_i2c_ts - use managed devm_device_add_group Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-09-30 01:40 +0200
csiph-web