Re: [PATCH 09/12] Input: raydium_i2c_ts - use managed devm_device_add_group

From	Dmitry Torokhov <dmitry.torokhov@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 09/12] Input: raydium_i2c_ts - use managed devm_device_add_group
Date	2017-09-30 01:40 +0200
Message-ID	<uvd2W-4rw-11@gated-at.bofh.it> (permalink)
References	<uvay6-2Kr-17@gated-at.bofh.it> <uvbu9-3kX-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sat, Sep 30, 2017 at 05:38:36AM +0900, Andi Shyti wrote:
> Commit 57b8ff070f98 ("driver core: add devm_device_add_group()
> and friends") has added the the managed version for creating
> sysfs group files.
> 
> Use devm_device_add_group instead of sysfs_create_group and
> remove the action that cleans the sysfs file when exiting the
> driver.
> 
> Signed-off-by: Andi Shyti <andi@etezian.org>

Applied, thank you.

> ---
>  drivers/input/touchscreen/raydium_i2c_ts.c | 18 +-----------------
>  1 file changed, 1 insertion(+), 17 deletions(-)
> 
> diff --git a/drivers/input/touchscreen/raydium_i2c_ts.c b/drivers/input/touchscreen/raydium_i2c_ts.c
> index 4f1d3fd5d412..100538d64fff 100644
> --- a/drivers/input/touchscreen/raydium_i2c_ts.c
> +++ b/drivers/input/touchscreen/raydium_i2c_ts.c
> @@ -943,13 +943,6 @@ static const struct attribute_group raydium_i2c_attribute_group = {
>  	.attrs = raydium_i2c_attributes,
>  };
>  
> -static void raydium_i2c_remove_sysfs_group(void *_data)
> -{
> -	struct raydium_data *ts = _data;
> -
> -	sysfs_remove_group(&ts->client->dev.kobj, &raydium_i2c_attribute_group);
> -}
> -
>  static int raydium_i2c_power_on(struct raydium_data *ts)
>  {
>  	int error;
> @@ -1120,7 +1113,7 @@ static int raydium_i2c_probe(struct i2c_client *client,
>  		return error;
>  	}
>  
> -	error = sysfs_create_group(&client->dev.kobj,
> +	error = devm_device_add_group(&client->dev,
>  				   &raydium_i2c_attribute_group);
>  	if (error) {
>  		dev_err(&client->dev, "failed to create sysfs attributes: %d\n",
> @@ -1128,15 +1121,6 @@ static int raydium_i2c_probe(struct i2c_client *client,
>  		return error;
>  	}
>  
> -	error = devm_add_action(&client->dev,
> -				raydium_i2c_remove_sysfs_group, ts);
> -	if (error) {
> -		raydium_i2c_remove_sysfs_group(ts);
> -		dev_err(&client->dev,
> -			"Failed to add sysfs cleanup action: %d\n", error);
> -		return error;
> -	}
> -
>  	return 0;
>  }
>  
> -- 
> 2.14.2
> 

-- 
Dmitry

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 00/12] use managed devm_device_add_group for all touchscreen drivers Andi Shyti <andi@etezian.org> - 2017-09-29 23:00 +0200
  [PATCH 08/12] Input: melfas_mip4 - use managed devm_device_add_group Andi Shyti <andi@etezian.org> - 2017-09-29 23:20 +0200
    Re: [PATCH 08/12] Input: melfas_mip4 - use managed  devm_device_add_group Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-09-30 01:40 +0200
  [PATCH 02/12] Input: ad7879 - use managed devm_device_add_group Andi Shyti <andi@etezian.org> - 2017-09-29 23:20 +0200
    Re: [PATCH 02/12] Input: ad7879 - use managed devm_device_add_group Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-09-30 01:50 +0200
  [PATCH 04/12] Input: atmel_mxt_ts - use managed devm_device_add_group Andi Shyti <andi@etezian.org> - 2017-09-29 23:20 +0200
    Re: [PATCH 04/12] Input: atmel_mxt_ts - use managed  devm_device_add_group Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-09-30 01:50 +0200
  [PATCH 12/12] Input: wdt87xx_i2c - use managed devm_device_add_group Andi Shyti <andi@etezian.org> - 2017-09-29 23:20 +0200
    Re: [PATCH 12/12] Input: wdt87xx_i2c - use managed  devm_device_add_group Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-09-30 01:50 +0200
  [PATCH 05/12] Input: edt-ft5x06 - use managed devm_device_add_group Andi Shyti <andi@etezian.org> - 2017-09-30 00:00 +0200
    Re: [PATCH 05/12] Input: edt-ft5x06 - use managed  devm_device_add_group Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-09-30 01:50 +0200
  [PATCH 06/12] Input: elants_i2c - use managed devm_device_add_group Andi Shyti <andi@etezian.org> - 2017-09-30 00:00 +0200
    Re: [PATCH 06/12] Input: elants_i2c - use managed  devm_device_add_group Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-09-30 01:40 +0200
  [PATCH 09/12] Input: raydium_i2c_ts -  use managed devm_device_add_group Andi Shyti <andi@etezian.org> - 2017-09-30 00:00 +0200
    Re: [PATCH 09/12] Input: raydium_i2c_ts -  use managed  devm_device_add_group Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-09-30 01:40 +0200

csiph-web