Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1742357

[PATCH 04/12] Input: atmel_mxt_ts - use managed devm_device_add_group

Show all headers | View raw

Commit 57b8ff070f98 ("driver core: add devm_device_add_group()
and friends") has added the the managed version for creating
sysfs group files.

Use devm_device_add_group instead of sysfs_create_group.

CC: Nick Dyer <nick@shmanahar.org>
Signed-off-by: Andi Shyti <andi@etezian.org>
---
 drivers/input/touchscreen/atmel_mxt_ts.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c b/drivers/input/touchscreen/atmel_mxt_ts.c
index 7659bc48f1db..e5968f136f08 100644
--- a/drivers/input/touchscreen/atmel_mxt_ts.c
+++ b/drivers/input/touchscreen/atmel_mxt_ts.c
@@ -3170,7 +3170,7 @@ static int mxt_probe(struct i2c_client *client, const struct i2c_device_id *id)
 	if (error)
 		return error;
 
-	error = sysfs_create_group(&client->dev.kobj, &mxt_attr_group);
+	error = devm_device_add_group(&client->dev, &mxt_attr_group);
 	if (error) {
 		dev_err(&client->dev, "Failure %d creating sysfs group\n",
 			error);
@@ -3190,7 +3190,6 @@ static int mxt_remove(struct i2c_client *client)
 	struct mxt_data *data = i2c_get_clientdata(client);
 
 	disable_irq(data->irq);
-	sysfs_remove_group(&client->dev.kobj, &mxt_attr_group);
 	mxt_free_input_device(data);
 	mxt_free_object_table(data);
 
-- 
2.14.2

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 00/12] use managed devm_device_add_group for all touchscreen drivers Andi Shyti <andi@etezian.org> - 2017-09-29 23:00 +0200
  [PATCH 08/12] Input: melfas_mip4 - use managed devm_device_add_group Andi Shyti <andi@etezian.org> - 2017-09-29 23:20 +0200
    Re: [PATCH 08/12] Input: melfas_mip4 - use managed  devm_device_add_group Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-09-30 01:40 +0200
  [PATCH 02/12] Input: ad7879 - use managed devm_device_add_group Andi Shyti <andi@etezian.org> - 2017-09-29 23:20 +0200
    Re: [PATCH 02/12] Input: ad7879 - use managed devm_device_add_group Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-09-30 01:50 +0200
  [PATCH 04/12] Input: atmel_mxt_ts - use managed devm_device_add_group Andi Shyti <andi@etezian.org> - 2017-09-29 23:20 +0200
    Re: [PATCH 04/12] Input: atmel_mxt_ts - use managed  devm_device_add_group Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-09-30 01:50 +0200
  [PATCH 12/12] Input: wdt87xx_i2c - use managed devm_device_add_group Andi Shyti <andi@etezian.org> - 2017-09-29 23:20 +0200
    Re: [PATCH 12/12] Input: wdt87xx_i2c - use managed  devm_device_add_group Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-09-30 01:50 +0200
  [PATCH 05/12] Input: edt-ft5x06 - use managed devm_device_add_group Andi Shyti <andi@etezian.org> - 2017-09-30 00:00 +0200
    Re: [PATCH 05/12] Input: edt-ft5x06 - use managed  devm_device_add_group Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-09-30 01:50 +0200
  [PATCH 06/12] Input: elants_i2c - use managed devm_device_add_group Andi Shyti <andi@etezian.org> - 2017-09-30 00:00 +0200
    Re: [PATCH 06/12] Input: elants_i2c - use managed  devm_device_add_group Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-09-30 01:40 +0200
  [PATCH 09/12] Input: raydium_i2c_ts -  use managed devm_device_add_group Andi Shyti <andi@etezian.org> - 2017-09-30 00:00 +0200
    Re: [PATCH 09/12] Input: raydium_i2c_ts -  use managed  devm_device_add_group Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-09-30 01:40 +0200

csiph-web