Re: [PATCH][net-next] net_sched: remove redundant assignment to ret

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH][net-next] net_sched: remove redundant assignment to ret
Date	2017-10-01 05:10 +0200
Message-ID	<uvCNI-4V8-5@gated-at.bofh.it> (permalink)
References	<uv49k-7bh-35@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Colin King <colin.king@canonical.com>
Date: Fri, 29 Sep 2017 15:01:16 +0100

> From: Colin Ian King <colin.king@canonical.com>
> 
> The assignment of -EINVAL to variable ret is redundant as it
> is being overwritten on the following error exit paths or
> to the return value from the following call to basic_set_parms.
> Fix this up by removing it. Cleans up clang warning message:
> 
> net/sched/cls_basic.c:185:2: warning: Value stored to 'err' is never read
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Applied.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH][net-next] net_sched: remove redundant assignment to ret Colin King <colin.king@canonical.com> - 2017-09-29 16:10 +0200
  Re: [PATCH][net-next] net_sched: remove redundant assignment to ret Cong Wang <xiyou.wangcong@gmail.com> - 2017-09-29 19:40 +0200
  Re: [PATCH][net-next] net_sched: remove redundant assignment to ret David Miller <davem@davemloft.net> - 2017-10-01 05:10 +0200

csiph-web