Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1742146

[PATCH][net-next] net_sched: remove redundant assignment to ret

Show all headers | View raw

From: Colin Ian King <colin.king@canonical.com>

The assignment of -EINVAL to variable ret is redundant as it
is being overwritten on the following error exit paths or
to the return value from the following call to basic_set_parms.
Fix this up by removing it. Cleans up clang warning message:

net/sched/cls_basic.c:185:2: warning: Value stored to 'err' is never read

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 net/sched/cls_basic.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/net/sched/cls_basic.c b/net/sched/cls_basic.c
index cfeb6f158566..700b345b07f9 100644
--- a/net/sched/cls_basic.c
+++ b/net/sched/cls_basic.c
@@ -182,7 +182,6 @@ static int basic_change(struct net *net, struct sk_buff *in_skb,
 	if (err < 0)
 		goto errout;
 
-	err = -EINVAL;
 	if (handle) {
 		fnew->handle = handle;
 		if (!fold) {
-- 
2.14.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH][net-next] net_sched: remove redundant assignment to ret Colin King <colin.king@canonical.com> - 2017-09-29 16:10 +0200
  Re: [PATCH][net-next] net_sched: remove redundant assignment to ret Cong Wang <xiyou.wangcong@gmail.com> - 2017-09-29 19:40 +0200
  Re: [PATCH][net-next] net_sched: remove redundant assignment to ret David Miller <davem@davemloft.net> - 2017-10-01 05:10 +0200

csiph-web