Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1742729
| From | David Miller <davem@davemloft.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH net-next] Revert "net: dsa: bcm_sf2: Defer port enabling to calling port_enable" |
| Date | 2017-10-01 05:10 +0200 |
| Message-ID | <uvCNH-4V8-1@gated-at.bofh.it> (permalink) |
| References | <uuLzH-3VY-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
From: Florian Fainelli <f.fainelli@gmail.com>
Date: Thu, 28 Sep 2017 11:19:06 -0700
> This reverts commit e85ec74ace29 ("net: dsa: bcm_sf2: Defer port
> enabling to calling port_enable") because this now makes an unbind
> followed by a bind to fail connecting to the ingrated PHY.
>
> What this patch missed is that we need the PHY to be enabled with
> bcm_sf2_gphy_enable_set() before probing it on the MDIO bus. This is
> correctly done in the ops->setup() function, but by the time
> ops->port_enable() runs, this is too late. Upon unbind we would power
> down the PHY, and so when we would bind again, the PHY would be left
> powered off.
>
> Fixes: e85ec74ace29 ("net: dsa: bcm_sf2: Defer port enabling to calling port_enable")
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Applied.
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH net-next] Revert "net: dsa: bcm_sf2: Defer port enabling to calling port_enable" Florian Fainelli <f.fainelli@gmail.com> - 2017-09-28 20:20 +0200 Re: [PATCH net-next] Revert "net: dsa: bcm_sf2: Defer port enabling to calling port_enable" David Miller <davem@davemloft.net> - 2017-10-01 05:10 +0200
csiph-web