[PATCH] irq/generic-chip: Fix memory leak of domain->name

From	Jeffy Chen <jeffy.chen@rock-chips.com>
Newsgroups	linux.kernel
Subject	[PATCH] irq/generic-chip: Fix memory leak of domain->name
Date	2017-09-27 14:30 +0200
Message-ID	<uujDs-2nV-17@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

Free domain->name when IRQ_DOMAIN_NAME_ALLOCATED been set.

Fixes: d59f6617eef0 ("genirq: Allow fwnode to carry name information only")
Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
---

 kernel/irq/generic-chip.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/kernel/irq/generic-chip.c b/kernel/irq/generic-chip.c
index f7086b78ad6e..174dae8ee7fe 100644
--- a/kernel/irq/generic-chip.c
+++ b/kernel/irq/generic-chip.c
@@ -322,6 +322,10 @@ int __irq_alloc_domain_generic_chips(struct irq_domain *d, int irqs_per_chip,
 		/* Calc pointer to the next generic chip */
 		tmp += sizeof(*gc) + num_ct * sizeof(struct irq_chip_type);
 	}
+	if (d->flags & IRQ_DOMAIN_NAME_ALLOCATED) {
+		kfree(d->name);
+		d->flags &= ~IRQ_DOMAIN_NAME_ALLOCATED;
+	}
 	d->name = name;
 	return 0;
 }
-- 
2.11.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] irq/generic-chip: Fix memory leak of domain->name Jeffy Chen <jeffy.chen@rock-chips.com> - 2017-09-27 14:30 +0200
  Re: [PATCH] irq/generic-chip: Fix memory leak of domain->name Thomas Gleixner <tglx@linutronix.de> - 2017-09-27 15:40 +0200
    Re: [PATCH] irq/generic-chip: Fix memory leak of domain->name jeffy <jeffy.chen@rock-chips.com> - 2017-09-28 05:20 +0200
      Re: [PATCH] irq/generic-chip: Fix memory leak of domain->name jeffy <jeffy.chen@rock-chips.com> - 2017-09-28 06:40 +0200

csiph-web