[PATCH] drm/rockchip: Fix memory leak in rockchip_drm_sys_resume()

From	Jeffy Chen <jeffy.chen@rock-chips.com>
Newsgroups	linux.kernel
Subject	[PATCH] drm/rockchip: Fix memory leak in rockchip_drm_sys_resume()
Date	2017-09-27 14:30 +0200
Message-ID	<uujDs-2nV-27@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

Free the drm_atomic_state allocated by drm_atomic_helper_suspend().

Fixes: 5a5873830972 ("drm/rockchip: Use atomic PM helpers")
Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
---

 drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
index 76d63de5921d..80235b672deb 100644
--- a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
@@ -15,6 +15,7 @@
  */
 
 #include <drm/drmP.h>
+#include <drm/drm_atomic.h>
 #include <drm/drm_crtc_helper.h>
 #include <drm/drm_fb_helper.h>
 #include <drm/drm_gem_cma_helper.h>
@@ -299,6 +300,7 @@ static int rockchip_drm_sys_resume(struct device *dev)
 
 	priv = drm->dev_private;
 	drm_atomic_helper_resume(drm, priv->state);
+	drm_atomic_state_put(priv->state);
 	rockchip_drm_fb_resume(drm);
 	drm_kms_helper_poll_enable(drm);
 
-- 
2.11.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] drm/rockchip: Fix memory leak in rockchip_drm_sys_resume() Jeffy Chen <jeffy.chen@rock-chips.com> - 2017-09-27 14:30 +0200
  Re: [PATCH] drm/rockchip: Fix memory leak in  rockchip_drm_sys_resume() Sean Paul <seanpaul@chromium.org> - 2017-09-27 22:30 +0200
    Re: [PATCH] drm/rockchip: Fix memory leak in rockchip_drm_sys_resume() jeffy <jeffy.chen@rock-chips.com> - 2017-09-28 05:20 +0200

csiph-web