Re: [PATCH] irq/generic-chip: Fix memory leak of domain->name

From	jeffy <jeffy.chen@rock-chips.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] irq/generic-chip: Fix memory leak of domain->name
Date	2017-09-28 06:40 +0200
Message-ID	<uuyMa-4cw-27@gated-at.bofh.it> (permalink)
References	<uujDs-2nV-17@gated-at.bofh.it> <uukJb-3qZ-3@gated-at.bofh.it> <uuxwK-3uo-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Thomas,

On 09/28/2017 11:18 AM, jeffy wrote:
>>
>> I don't think that this is the proper thing to do. There is no reason why
>> the domain should have the same name as the irq chip. So we rather should
>> do:
>>
>>     if (!d->name)
>>         d->name = name;
>>
>> Along with a proper comment.
> that is better, will do it in next version :)

it looks like the __irq_domain_add() would guarantee every domain has a 
valid name, maybe we can just remove this?

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] irq/generic-chip: Fix memory leak of domain->name Jeffy Chen <jeffy.chen@rock-chips.com> - 2017-09-27 14:30 +0200
  Re: [PATCH] irq/generic-chip: Fix memory leak of domain->name Thomas Gleixner <tglx@linutronix.de> - 2017-09-27 15:40 +0200
    Re: [PATCH] irq/generic-chip: Fix memory leak of domain->name jeffy <jeffy.chen@rock-chips.com> - 2017-09-28 05:20 +0200
      Re: [PATCH] irq/generic-chip: Fix memory leak of domain->name jeffy <jeffy.chen@rock-chips.com> - 2017-09-28 06:40 +0200

csiph-web