Re: [PATCH v2 27/31] usb/gadget/snps_udc_core: Remove struct timer_list.data use

From	Felipe Balbi <balbi@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 27/31] usb/gadget/snps_udc_core: Remove struct timer_list.data use
Date	2017-09-28 11:40 +0200
Message-ID	<uuDsu-7h4-7@gated-at.bofh.it> (permalink)
References	<urWBj-1gx-3@gated-at.bofh.it> <urWUF-1nO-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Kees Cook <keescook@chromium.org> writes:

> If the probe fails, udc_remove() will not be called, so there is no
> reason to make del_timer_sync() calls conditional. As a result, use of
> the .data field can be dropped, in support of making removing this field
> entirely from struct timer_list.
>
> Cc: Felipe Balbi <balbi@kernel.org>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Raviteja Garimella <raviteja.garimella@broadcom.com>
> Cc: Michal Nazarewicz <mina86@mina86.com>
> Cc: "Gustavo A. R. Silva" <garsilva@embeddedor.com>
> Cc: linux-usb@vger.kernel.org
> Signed-off-by: Kees Cook <keescook@chromium.org>

Acked-by: Felipe Balbi <felipe.balbi@linux.intel.com>

-- 
balbi

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v2 27/31] usb/gadget/snps_udc_core: Remove struct timer_list.data use Felipe Balbi <balbi@kernel.org> - 2017-09-28 11:40 +0200

csiph-web