Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1741332 > unrolled thread

Re: [PATCH v2 27/31] usb/gadget/snps_udc_core: Remove struct timer_list.data use

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v2 27/31] usb/gadget/snps_udc_core: Remove struct timer_list.data use Felipe Balbi <balbi@kernel.org> - 2017-09-28 11:40 +0200

#1741332 — Re: [PATCH v2 27/31] usb/gadget/snps_udc_core: Remove struct timer_list.data use

[Multipart message — attachments visible in raw view] — view raw

Kees Cook <keescook@chromium.org> writes:

> If the probe fails, udc_remove() will not be called, so there is no
> reason to make del_timer_sync() calls conditional. As a result, use of
> the .data field can be dropped, in support of making removing this field
> entirely from struct timer_list.
>
> Cc: Felipe Balbi <balbi@kernel.org>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Raviteja Garimella <raviteja.garimella@broadcom.com>
> Cc: Michal Nazarewicz <mina86@mina86.com>
> Cc: "Gustavo A. R. Silva" <garsilva@embeddedor.com>
> Cc: linux-usb@vger.kernel.org
> Signed-off-by: Kees Cook <keescook@chromium.org>

Acked-by: Felipe Balbi <felipe.balbi@linux.intel.com>

-- 
balbi

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web