Re: [PATCH v2 16/31] usb/phy-isp1301-omap: Remove .data assignment

From	Felipe Balbi <balbi@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 16/31] usb/phy-isp1301-omap: Remove .data assignment
Date	2017-09-28 11:40 +0200
Message-ID	<uuDsu-7h4-3@gated-at.bofh.it> (permalink)
References	<urWBj-1gx-3@gated-at.bofh.it> <urWBk-1gx-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi,

Kees Cook <keescook@chromium.org> writes:
> The .data assignment appears to be redundant to the WORK_STOP bit for
> stopping the timer. Also, it appears this timer is entirely unused
> as it is only ever started under #define VERBOSE, which is explicitly
> undefined.
>
> Cc: Felipe Balbi <balbi@kernel.org>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: linux-usb@vger.kernel.org
> Cc: linux-omap@vger.kernel.org
> Signed-off-by: Kees Cook <keescook@chromium.org>

Are you merging these as part of a larger series altogether, or should I
pick the patches that concern me?

If you're taking them all together:

Acked-by: Felipe Balbi <felipe.balbi@linux.intel.com>

-- 
balbi

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v2 16/31] usb/phy-isp1301-omap: Remove .data assignment Felipe Balbi <balbi@kernel.org> - 2017-09-28 11:40 +0200

csiph-web