Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1741331 > unrolled thread

Re: [PATCH v2 16/31] usb/phy-isp1301-omap: Remove .data assignment

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v2 16/31] usb/phy-isp1301-omap: Remove .data assignment Felipe Balbi <balbi@kernel.org> - 2017-09-28 11:40 +0200

#1741331 — Re: [PATCH v2 16/31] usb/phy-isp1301-omap: Remove .data assignment

[Multipart message — attachments visible in raw view] — view raw

Hi,

Kees Cook <keescook@chromium.org> writes:
> The .data assignment appears to be redundant to the WORK_STOP bit for
> stopping the timer. Also, it appears this timer is entirely unused
> as it is only ever started under #define VERBOSE, which is explicitly
> undefined.
>
> Cc: Felipe Balbi <balbi@kernel.org>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: linux-usb@vger.kernel.org
> Cc: linux-omap@vger.kernel.org
> Signed-off-by: Kees Cook <keescook@chromium.org>

Are you merging these as part of a larger series altogether, or should I
pick the patches that concern me?

If you're taking them all together:

Acked-by: Felipe Balbi <felipe.balbi@linux.intel.com>

-- 
balbi

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web