Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1738923

Re: [PATCH net-next] net: mvpp2: phylink support

Show all headers | View raw

On Mon, Sep 25, 2017 at 11:55:14AM +0200, Antoine Tenart wrote:
> Hi Russell,
> 
> On Fri, Sep 22, 2017 at 12:07:31PM +0100, Russell King - ARM Linux wrote:
> > On Thu, Sep 21, 2017 at 03:45:22PM +0200, Antoine Tenart wrote:
> > > Convert the PPv2 driver to use phylink, which models the MAC to PHY
> > > link. The phylink support is made such a way the GoP link IRQ can still
> > > be used: the two modes are incompatible and the GoP link IRQ will be
> > > used if no PHY is described in the device tree. This is the same
> > > behaviour as before.
> > 
> > This makes no sense.  The point of phylink is to be able to support SFP
> > cages, and SFP cages do not have a PHY described in DT.  So, when you
> > want to use phylink because of SFP, you can't, because if you omit
> > the PHY the driver avoids using phylink.
> 
> Yes that's an issue. However we do need to support the GoP link IRQ
> which is also needed in some cases where there is no PHY (and when
> phylink cannot be used). What would you propose to differentiate those
> two cases: no PHY using phylink, and no PHY using the GoP link IRQ?

Can you describe what the GoP link IRQ is doing please?

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up
According to speedtest.net: 8.21Mbps down 510kbps up

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH net-next] net: mvpp2: phylink support Antoine Tenart <antoine.tenart@free-electrons.com> - 2017-09-21 15:50 +0200
  Re: [PATCH net-next] net: mvpp2: phylink support Marcin Wojtas <mw@semihalf.com> - 2017-09-22 10:00 +0200
  Re: [PATCH net-next] net: mvpp2: phylink support Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-09-22 13:10 +0200
    Re: [PATCH net-next] net: mvpp2: phylink support Antoine Tenart <antoine.tenart@free-electrons.com> - 2017-09-25 12:00 +0200
      Re: [PATCH net-next] net: mvpp2: phylink support Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-09-25 12:50 +0200
        Re: [PATCH net-next] net: mvpp2: phylink support Antoine Tenart <antoine.tenart@free-electrons.com> - 2017-09-25 14:00 +0200
          Re: [PATCH net-next] net: mvpp2: phylink support Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-09-25 14:20 +0200
            Re: [PATCH net-next] net: mvpp2: phylink support Antoine Tenart <antoine.tenart@free-electrons.com> - 2017-09-25 15:10 +0200

csiph-web