Re: [linux-sunxi] Re: [PATCH 0/3] Simple DVFS support for Allwinner A64 SoC

From	Maxime Ripard <maxime.ripard@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [linux-sunxi] Re: [PATCH 0/3] Simple DVFS support for Allwinner A64 SoC
Date	2017-09-25 12:50 +0200
Message-ID	<utz7B-5aK-23@gated-at.bofh.it> (permalink)
References	<usGkO-4r6-3@gated-at.bofh.it> <utyEx-4YG-5@gated-at.bofh.it> <utyEy-4YG-17@gated-at.bofh.it> <utyOe-528-7@gated-at.bofh.it> <utyXU-55N-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Mon, Sep 25, 2017 at 10:29:38AM +0000, Icenowy Zheng wrote:
> 
> 
> 于 2017年9月25日 GMT+08:00 下午6:27:44, Maxime Ripard <maxime.ripard@free-electrons.com> 写到:
> >On Mon, Sep 25, 2017 at 10:12:09AM +0000, Icenowy Zheng wrote:
> >> 于 2017年9月25日 GMT+08:00 下午6:10:27, Maxime Ripard
> ><maxime.ripard@free-electrons.com> 写到:
> >> >Hi,
> >> >
> >> >On Sat, Sep 23, 2017 at 12:15:28AM +0000, Icenowy Zheng wrote:
> >> >> This patchset imports simple DVFS support for Allwinner A64 SoC.
> >> >> 
> >> >> As the thermal sensor driver is not yet implemented and some
> >boards
> >> >> have still no AXP PMIC support, now only two OPPs are present --
> >> >> 648MHz@1.04V and 816MHz@1.1V to prevent overheat or undervoltage.
> >> >> 
> >> >> PATCH 1 is a fix to the CCU driver of A64, and the remaining
> >patches
> >> >> set up the device tree bits of the DVFS on Pine64.
> >> >
> >> >How has this been tested?
> >> >
> >> >What tasks did you run, with what governor, etc...
> >> 
> >> I only tested manual frequency switching between 648MHz and
> >> 816MHz, and tested the PLL stuck issue by change the OPPs to
> >> some random value.
> >
> >Ideally, we should test that it's actually reliable. Poorly chosen
> >OPPs might lead to corrupt data that you might not get before a while.
> 
> These are OPPs from the official sys_config.fex .

And the rest of the code isn't, such as the clock or regulator code
that is critical as well here.

I'm not asking this out of nowhere, we've had to debug this more than
once already.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/3] Simple DVFS support for Allwinner A64 SoC Icenowy Zheng <icenowy@aosc.io> - 2017-09-23 02:20 +0200
  [PATCH 1/3] clk: sunxi-ng: add mux and pll notifiers for A64 CPU clock Icenowy Zheng <icenowy@aosc.io> - 2017-09-23 02:20 +0200
  Re: [PATCH 0/3] Simple DVFS support for Allwinner A64 SoC Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-09-25 12:20 +0200
    Re: [PATCH 0/3] Simple DVFS support for Allwinner A64 SoC Icenowy Zheng <icenowy@aosc.io> - 2017-09-25 12:20 +0200
      Re: [PATCH 0/3] Simple DVFS support for Allwinner A64 SoC Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-09-25 12:30 +0200
        Re: [linux-sunxi] Re: [PATCH 0/3] Simple DVFS support for Allwinner A64 SoC Icenowy Zheng <icenowy@aosc.io> - 2017-09-25 12:40 +0200
          Re: [linux-sunxi] Re: [PATCH 0/3] Simple DVFS support for Allwinner  A64 SoC Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-09-25 12:50 +0200

csiph-web