Re: [PATCH net-next] net: mvpp2: phylink support

From	Antoine Tenart <antoine.tenart@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH net-next] net: mvpp2: phylink support
Date	2017-09-25 15:10 +0200
Message-ID	<utBj4-6Ms-13@gated-at.bofh.it> (permalink)
References	(1 earlier) <usu0h-5oP-7@gated-at.bofh.it> <utylc-4Cl-5@gated-at.bofh.it> <utz7B-5aK-29@gated-at.bofh.it> <utAdj-5RX-1@gated-at.bofh.it> <utAwF-6f6-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Sep 25, 2017 at 01:13:43PM +0100, Russell King - ARM Linux wrote:
> On Mon, Sep 25, 2017 at 01:53:03PM +0200, Antoine Tenart wrote:
> > On Mon, Sep 25, 2017 at 11:45:32AM +0100, Russell King - ARM Linux wrote:
> > > Can you describe what the GoP link IRQ is doing please?
> > 
> > In cases where there is no PHY connected to the MAC and no SFP cage is
> > used. One example is when a SOHO switch is connected directly to a
> > serdes lane. In such cases we still need to have a minimal link
> > management. The GoP link interrupt helps doing so as it raises when the
> > serdes is in sync and AN succeeded.
> 
> Isn't this just like a fixed link scenario, or an in-band
> autonegotiation scenario (both of which phylink supports natively)?
> 
> The situation on Clearfog with the 88E6176 switch is pretty similar -
> a switch connected directly via serdes to the MAC.  Currently, we
> configure stuff there as a fixed link, but in actual fact the 88E6176
> is configured to run the CPU facing port in 1000base-X mode, and with
> appropriate tweaks, switching phylink to 1000base-X mode also works.

Hmm, I think you're right, we should be able to represent the link
between the MAC and the switch as a fixed link. And when it's not fixed,
it could be done with in-band AN. I cannot test this myself but I've
asked someone who can to.

Antoine

-- 
Antoine Ténart, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH net-next] net: mvpp2: phylink support Antoine Tenart <antoine.tenart@free-electrons.com> - 2017-09-21 15:50 +0200
  Re: [PATCH net-next] net: mvpp2: phylink support Marcin Wojtas <mw@semihalf.com> - 2017-09-22 10:00 +0200
  Re: [PATCH net-next] net: mvpp2: phylink support Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-09-22 13:10 +0200
    Re: [PATCH net-next] net: mvpp2: phylink support Antoine Tenart <antoine.tenart@free-electrons.com> - 2017-09-25 12:00 +0200
      Re: [PATCH net-next] net: mvpp2: phylink support Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-09-25 12:50 +0200
        Re: [PATCH net-next] net: mvpp2: phylink support Antoine Tenart <antoine.tenart@free-electrons.com> - 2017-09-25 14:00 +0200
          Re: [PATCH net-next] net: mvpp2: phylink support Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-09-25 14:20 +0200
            Re: [PATCH net-next] net: mvpp2: phylink support Antoine Tenart <antoine.tenart@free-electrons.com> - 2017-09-25 15:10 +0200

csiph-web