Re: [RFC PATCH 3/7] iio: adc: axp20x-adc: add support for AXP803

From	Quentin Schulz <quentin.schulz@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH 3/7] iio: adc: axp20x-adc: add support for AXP803
Date	2017-09-25 10:50 +0200
Message-ID	<utxfr-3VY-9@gated-at.bofh.it> (permalink)
References	<urOX7-4Mq-7@gated-at.bofh.it> <urOX8-4Mq-33@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Icenowy,

On 20/09/2017 17:18, Icenowy Zheng wrote:
> AXP803 SoC features an ADC part including these channels: GPADC (GPIO0)
> and TS pins, PMIC internal temperature sensor, battery voltage, battery
> charge/discharge current.
> 
> Add support for the battery-related channels and internal temperature
> channel in order to allow battery monitoring. The TS and GPADC channels
> are complex and will be support after more investigation.
> 
> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
> ---
>  drivers/iio/adc/axp20x_adc.c | 108 +++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 108 insertions(+)
> 
> diff --git a/drivers/iio/adc/axp20x_adc.c b/drivers/iio/adc/axp20x_adc.c
> index 93dd6b80059e..4f0cd98cf6ea 100644
> --- a/drivers/iio/adc/axp20x_adc.c
> +++ b/drivers/iio/adc/axp20x_adc.c
> @@ -28,6 +28,8 @@
[...]>  /*
> + * AXP803 shares the same consumer map with AXP22x, as it has no ADC for
> + * VBUS and ACIN inputs either.
> + */
> +
> +/*

Put that in the commit log?
If we add a comment for each newly supported PMIC we will end up with
more comments than code :)

[...]>
> +static const struct axp_data axp803_data = {
> +	.iio_info = &axp803_adc_iio_info,
> +	.num_channels = ARRAY_SIZE(axp803_adc_channels),
> +	.channels = axp803_adc_channels,
> +	.adc_en1_mask = AXP803_ADC_EN1_MASK,
> +	.adc_en2 = false,

Not required I guess, by default it is false.

Thanks,
Quentin
-- 
Quentin Schulz, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Thread

[RFC PATCH 0/7] AXP803 AC/Battery support Icenowy Zheng <icenowy@aosc.io> - 2017-09-20 17:20 +0200
  [RFC PATCH 1/7] dt-bindings: add compatibles for AXP803 Battery/USB power supplies Icenowy Zheng <icenowy@aosc.io> - 2017-09-20 17:20 +0200
    Re: [RFC PATCH 1/7] dt-bindings: add compatibles for AXP803  Battery/USB power supplies Quentin Schulz <quentin.schulz@free-electrons.com> - 2017-09-25 11:20 +0200
  [RFC PATCH 3/7] iio: adc: axp20x-adc: add support for AXP803 Icenowy Zheng <icenowy@aosc.io> - 2017-09-20 17:20 +0200
    Re: [RFC PATCH 3/7] iio: adc: axp20x-adc: add support for AXP803 Jonathan Cameron <jic23@kernel.org> - 2017-09-24 16:40 +0200
    Re: [RFC PATCH 3/7] iio: adc: axp20x-adc: add support for AXP803 Quentin Schulz <quentin.schulz@free-electrons.com> - 2017-09-25 10:50 +0200
  [RFC PATCH 5/7] mfd: axp20x: add cells for AXP803 ADC/AC Power/Battery Icenowy Zheng <icenowy@aosc.io> - 2017-09-20 17:20 +0200
  [RFC PATCH 7/7] arm64: allwinner: a64: enable AC and Battery for Pine64 Icenowy Zheng <icenowy@aosc.io> - 2017-09-20 17:30 +0200
  [RFC PATCH 6/7] arm64: allwinner: a64: add power supply nodes in AXP803 DTSI Icenowy Zheng <icenowy@aosc.io> - 2017-09-20 17:30 +0200
    Re: [RFC PATCH 6/7] arm64: allwinner: a64: add power supply nodes in  AXP803 DTSI Quentin Schulz <quentin.schulz@free-electrons.com> - 2017-09-25 11:20 +0200
      Re: [RFC PATCH 6/7] arm64: allwinner: a64: add power supply nodes in AXP803 DTSI Icenowy Zheng <icenowy@aosc.io> - 2017-09-25 11:20 +0200
        Re: [linux-sunxi] Re: [RFC PATCH 6/7] arm64: allwinner: a64: add  power supply nodes in AXP803 DTSI Chen-Yu Tsai <wens@csie.org> - 2017-09-25 11:30 +0200
        Re: [RFC PATCH 6/7] arm64: allwinner: a64: add power supply nodes in  AXP803 DTSI Quentin Schulz <quentin.schulz@free-electrons.com> - 2017-09-25 11:30 +0200
  Re: [RFC PATCH 0/7] AXP803 AC/Battery support Jonathan Cameron <Jonathan.Cameron@huawei.com> - 2017-09-21 16:50 +0200
    Re: [RFC PATCH 0/7] AXP803 AC/Battery support Icenowy Zheng <icenowy@aosc.io> - 2017-09-21 17:30 +0200
      Re: [RFC PATCH 0/7] AXP803 AC/Battery support Jonathan Cameron <jic23@kernel.org> - 2017-09-24 16:40 +0200
        Re: [RFC PATCH 0/7] AXP803 AC/Battery support Quentin Schulz <quentin.schulz@free-electrons.com> - 2017-09-25 11:30 +0200

csiph-web