Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1738855
| From | Chen-Yu Tsai <wens@csie.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [linux-sunxi] Re: [RFC PATCH 6/7] arm64: allwinner: a64: add power supply nodes in AXP803 DTSI |
| Date | 2017-09-25 11:30 +0200 |
| Message-ID | <utxSa-4rR-3@gated-at.bofh.it> (permalink) |
| References | <urOX7-4Mq-7@gated-at.bofh.it> <urP6O-4Qg-17@gated-at.bofh.it> <utxIu-4nC-13@gated-at.bofh.it> <utxIu-4nC-17@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Mon, Sep 25, 2017 at 5:14 PM, Icenowy Zheng <icenowy@aosc.io> wrote:
>
>
> 于 2017年9月25日 GMT+08:00 下午5:11:57, Quentin Schulz <quentin.schulz@free-electrons.com> 写到:
>>Hi Icenowy,
>>
>>On 20/09/2017 17:18, Icenowy Zheng wrote:
>>> AXP803 PMIC features AC/USB/Battery power supplies.
>>>
>>> As we have now the device tree bindings for them, add device tree
>>> nodes for them.
>>>
>>> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
>>> ---
>>> arch/arm64/boot/dts/allwinner/axp803.dtsi | 15 +++++++++++++++
>>> 1 file changed, 15 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/allwinner/axp803.dtsi
>>b/arch/arm64/boot/dts/allwinner/axp803.dtsi
>>> index ff8af52743ff..3a8615231b7c 100644
>>> --- a/arch/arm64/boot/dts/allwinner/axp803.dtsi
>>> +++ b/arch/arm64/boot/dts/allwinner/axp803.dtsi
>>> @@ -49,6 +49,16 @@
>>> interrupt-controller;
>>> #interrupt-cells = <1>;
>>>
>>> + ac_power_supply: ac-power-supply {
>>> + compatible = "x-powers,axp221-ac-power-supply";
>>> + status = "disabled";
>>> + };
>>> +
>>> + battery_power_supply: battery-power-supply {
>>> + compatible = "x-powers,axp803-battery-power-supply";
>>> + status = "disabled";
>>> + };
>>> +
>>> regulators {
>>> /* Default work frequency for buck regulators */
>>> x-powers,dcdc-freq = <3000>;
>>> @@ -147,4 +157,9 @@
>>> regulator-name = "rtc-ldo";
>>> };
>>> };
>>> +
>>> + usb_power_supply: usb_power_supply {
>>> + compatible = "x-powers,axp803-usb-power-supply";
>>> + status = "disabled";
>>> + };
>>
>>No. You have added support for the AC and battery power supply drivers
>>in this patchset, not for USB.
>
> But I added its device tree binding.
Please do both at the same time. If you only add the binding without
the driver, how can you be sure the binding would be a proper fit?
Moreover, no one can actually test it.
ChenYu
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[RFC PATCH 0/7] AXP803 AC/Battery support Icenowy Zheng <icenowy@aosc.io> - 2017-09-20 17:20 +0200
[RFC PATCH 1/7] dt-bindings: add compatibles for AXP803 Battery/USB power supplies Icenowy Zheng <icenowy@aosc.io> - 2017-09-20 17:20 +0200
Re: [RFC PATCH 1/7] dt-bindings: add compatibles for AXP803 Battery/USB power supplies Quentin Schulz <quentin.schulz@free-electrons.com> - 2017-09-25 11:20 +0200
[RFC PATCH 3/7] iio: adc: axp20x-adc: add support for AXP803 Icenowy Zheng <icenowy@aosc.io> - 2017-09-20 17:20 +0200
Re: [RFC PATCH 3/7] iio: adc: axp20x-adc: add support for AXP803 Jonathan Cameron <jic23@kernel.org> - 2017-09-24 16:40 +0200
Re: [RFC PATCH 3/7] iio: adc: axp20x-adc: add support for AXP803 Quentin Schulz <quentin.schulz@free-electrons.com> - 2017-09-25 10:50 +0200
[RFC PATCH 5/7] mfd: axp20x: add cells for AXP803 ADC/AC Power/Battery Icenowy Zheng <icenowy@aosc.io> - 2017-09-20 17:20 +0200
[RFC PATCH 7/7] arm64: allwinner: a64: enable AC and Battery for Pine64 Icenowy Zheng <icenowy@aosc.io> - 2017-09-20 17:30 +0200
[RFC PATCH 6/7] arm64: allwinner: a64: add power supply nodes in AXP803 DTSI Icenowy Zheng <icenowy@aosc.io> - 2017-09-20 17:30 +0200
Re: [RFC PATCH 6/7] arm64: allwinner: a64: add power supply nodes in AXP803 DTSI Quentin Schulz <quentin.schulz@free-electrons.com> - 2017-09-25 11:20 +0200
Re: [RFC PATCH 6/7] arm64: allwinner: a64: add power supply nodes in AXP803 DTSI Icenowy Zheng <icenowy@aosc.io> - 2017-09-25 11:20 +0200
Re: [linux-sunxi] Re: [RFC PATCH 6/7] arm64: allwinner: a64: add power supply nodes in AXP803 DTSI Chen-Yu Tsai <wens@csie.org> - 2017-09-25 11:30 +0200
Re: [RFC PATCH 6/7] arm64: allwinner: a64: add power supply nodes in AXP803 DTSI Quentin Schulz <quentin.schulz@free-electrons.com> - 2017-09-25 11:30 +0200
Re: [RFC PATCH 0/7] AXP803 AC/Battery support Jonathan Cameron <Jonathan.Cameron@huawei.com> - 2017-09-21 16:50 +0200
Re: [RFC PATCH 0/7] AXP803 AC/Battery support Icenowy Zheng <icenowy@aosc.io> - 2017-09-21 17:30 +0200
Re: [RFC PATCH 0/7] AXP803 AC/Battery support Jonathan Cameron <jic23@kernel.org> - 2017-09-24 16:40 +0200
Re: [RFC PATCH 0/7] AXP803 AC/Battery support Quentin Schulz <quentin.schulz@free-electrons.com> - 2017-09-25 11:30 +0200
csiph-web