RE: [PATCH V2] megaraid: kmemleak: Track page allocation for fusion

From	Shivasharan Srikanteshwara <shivasharan.srikanteshwara@broadcom.com>
Newsgroups	linux.kernel
Subject	RE: [PATCH V2] megaraid: kmemleak: Track page allocation for fusion
Date	2017-09-25 10:50 +0200
Message-ID	<utxfr-3VY-5@gated-at.bofh.it> (permalink)
References	<upRmp-6R3-3@gated-at.bofh.it> <uq3dT-6zx-1@gated-at.bofh.it> <ur602-7Z6-15@gated-at.bofh.it> <ur75L-b2-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> -----Original Message-----
> From: Christoph Hellwig [mailto:hch@infradead.org]
> Sent: Monday, September 18, 2017 9:52 PM
> To: Shivasharan Srikanteshwara
> Cc: Christoph Hellwig; shuwang@redhat.com; Kashyap Desai; Sumit Saxena;
> jejb@linux.vnet.ibm.com; martin.petersen@oracle.com;
> PDL,MEGARAIDLINUX; linux-scsi@vger.kernel.org; linux-
> kernel@vger.kernel.org; chuhu@redhat.com; yizhan@redhat.com;
> catalin.marinas@arm.com
> Subject: Re: [PATCH V2] megaraid: kmemleak: Track page allocation for
fusion
>
> Oh, I missed log_to_span.  Well, in that case log_to_span is _the_
candidate
> for moving into a separate allocation.
>
> And in fact you're probably better off by using a sensible data
structure for it,
> e.g. a radix tree.

Thanks Christoph.
We will make the changes suggested in phased approach.
First we will fix kmemleak false positives by moving log_to_span
allocation separate from fusion_context.
The data structure change would involve major changes which affects IO
path as well.
Also driver expects log_to_span and other data structures to be available
at load time itself. Considering this, we need to understand if radix tree
would be a good choice for the change.
Based on internal discussions, we see other similar arrays in driver code
that we can change similarly eg. load_balance_info.
This is definitely something to add to our to-do lists.
These changes need to go through our internal regression test cycle and
then submit it to upstream.

Best regards,
Shivasharan

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH V2] megaraid: kmemleak: Track page allocation for fusion shuwang@redhat.com - 2017-09-15 07:30 +0200
  Re: [PATCH V2] megaraid: kmemleak: Track page allocation for fusion Catalin Marinas <catalin.marinas@arm.com> - 2017-09-15 15:20 +0200
  Re: [PATCH V2] megaraid: kmemleak: Track page allocation for fusion Bart Van Assche <Bart.VanAssche@wdc.com> - 2017-09-15 18:20 +0200
  Re: [PATCH V2] megaraid: kmemleak: Track page allocation for fusion Christoph Hellwig <hch@infradead.org> - 2017-09-15 20:10 +0200
    RE: [PATCH V2] megaraid: kmemleak: Track page allocation for fusion Shivasharan Srikanteshwara          <shivasharan.srikanteshwara@broadcom.com> - 2017-09-18 17:20 +0200
      Re: [PATCH V2] megaraid: kmemleak: Track page allocation for fusion Christoph Hellwig <hch@infradead.org> - 2017-09-18 18:30 +0200
        RE: [PATCH V2] megaraid: kmemleak: Track page allocation for fusion Shivasharan Srikanteshwara          <shivasharan.srikanteshwara@broadcom.com> - 2017-09-25 10:50 +0200

csiph-web