Re: [PATCH] printk: simplify no_printk()

From	Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] printk: simplify no_printk()
Date	2017-09-26 08:50 +0200
Message-ID	<utRQS-150-17@gated-at.bofh.it> (permalink)
References	<uqJmN-19W-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On (09/18/17 00:01), Masahiro Yamada wrote:
> Commit 069f0cd00df0 ("printk: Make the printk*once() variants return
> a value") surrounded the macro implementation with ({ ... }).
> 
> Now, the inner do { ... } while (0); is redundant.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>

looks ok to me. can't say that I see a huge difference, tho,
but, FWIW:

Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>

	-ss

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] printk: simplify no_printk() Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-09-17 17:10 +0200
  Re: [PATCH] printk: simplify no_printk() Joe Perches <joe@perches.com> - 2017-09-17 20:40 +0200
  Re: [PATCH] printk: simplify no_printk() Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2017-09-26 08:50 +0200

csiph-web