Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1739554

Re: [git pull] vfs.git regression fix Re: Regression related to ipc shmctl compat

From Christoph Hellwig <hch@infradead.org>
Newsgroups linux.kernel
Subject Re: [git pull] vfs.git regression fix Re: Regression related to ipc shmctl compat
Date 2017-09-26 08:50 +0200
Message-ID <utRQS-150-15@gated-at.bofh.it> (permalink)
References <utJTk-47L-39@gated-at.bofh.it> <utMxQ-5WZ-11@gated-at.bofh.it> <utN0R-69H-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Mon, Sep 25, 2017 at 06:37:28PM -0700, Linus Torvalds wrote:
> Pulled and pushed out, but I'd like to note that sparse would have
> caught this. Except we are so far away from being sparse-clean that
> nobody runs it.

I tend to run sparse over the nvme code before sending pull request
every time.  But it's a fairly new codebase, so it it actually
is clean.  I wish we'd just default to running sparse at some point
so people have to clean their shit up, as it catches a lot of
useful things.  But maybe for the default we want to tune it down
a bit (e.g. don't warn about missing statics by default, skip
the lock imbalance checks which while often useful also generate
tons of false positives).

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

Regression related to ipc shmctl compat Kyle Huey <me@kylehuey.com> - 2017-09-26 00:20 +0200
  [git pull] vfs.git regression fix Re: Regression related to ipc  shmctl compat Al Viro <viro@ZenIV.linux.org.uk> - 2017-09-26 03:10 +0200
    Re: [git pull] vfs.git regression fix Re: Regression related to ipc  shmctl compat Linus Torvalds <torvalds@linux-foundation.org> - 2017-09-26 03:40 +0200
      Re: [git pull] vfs.git regression fix Re: Regression related to ipc  shmctl compat Al Viro <viro@ZenIV.linux.org.uk> - 2017-09-26 03:50 +0200
        Re: [git pull] vfs.git regression fix Re: Regression related to ipc  shmctl compat Al Viro <viro@ZenIV.linux.org.uk> - 2017-09-26 04:10 +0200
          Re: [git pull] vfs.git regression fix Re: Regression related to ipc  shmctl compat Linus Torvalds <torvalds@linux-foundation.org> - 2017-09-26 04:10 +0200
            Re: [git pull] vfs.git regression fix Re: Regression related to ipc  shmctl compat Linus Torvalds <torvalds@linux-foundation.org> - 2017-09-26 04:10 +0200
              Re: [git pull] vfs.git regression fix Re: Regression related to ipc  shmctl compat Al Viro <viro@ZenIV.linux.org.uk> - 2017-09-26 05:10 +0200
              Re: [git pull] vfs.git regression fix Re: Regression related to ipc  shmctl compat Luc Van Oostenryck <luc.vanoostenryck@gmail.com> - 2017-09-26 21:50 +0200
        Re: [git pull] vfs.git regression fix Re: Regression related to ipc  shmctl compat Linus Torvalds <torvalds@linux-foundation.org> - 2017-09-26 04:10 +0200
      Re: [git pull] vfs.git regression fix Re: Regression related to ipc  shmctl compat Christoph Hellwig <hch@infradead.org> - 2017-09-26 08:50 +0200
        Script to do smart sparse diffs (was Re: [git pull] vfs.git regression fix Re: Regression related to ipc shmctl compat) Michael Ellerman <mpe@ellerman.id.au> - 2017-09-28 08:20 +0200

csiph-web