Re: [PATCH] Drivers: pinctrl: intel fixed typo

From	Mika Westerberg <mika.westerberg@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] Drivers: pinctrl: intel fixed typo
Date	2017-09-26 08:50 +0200
Message-ID	<utRQS-150-21@gated-at.bofh.it> (permalink)
References	<utGC6-1Kz-23@gated-at.bofh.it>
Organization	Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

Show all headers | View raw

On Mon, Sep 25, 2017 at 02:41:56PM -0400, Chris Gorman wrote:
> fixed typo in comment for north_community
> 
> Signed-off-by: Chris Gorman <chrisjohgorman@gmail.com>

Please fix title to be something like "pinctrl: cherryview: Fix typo
in comment". And also in the commit message, start it with capital
letter and end with "." like:

Fixed typo on comment for north_community.

The patch itself looks good.

Thanks!

> ---
>  drivers/pinctrl/intel/pinctrl-cherryview.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pinctrl/intel/pinctrl-cherryview.c b/drivers/pinctrl/intel/pinctrl-cherryview.c
> index 04e929f..8d50eae 100644
> --- a/drivers/pinctrl/intel/pinctrl-cherryview.c
> +++ b/drivers/pinctrl/intel/pinctrl-cherryview.c
> @@ -491,7 +491,7 @@ static const struct chv_community north_community = {
>  	.ngpio_ranges = ARRAY_SIZE(north_gpio_ranges),
>  	.ngpios = ARRAY_SIZE(north_pins),
>  	/*
> -	 * North community can benerate GPIO interrupts only for the first
> +	 * North community can generate GPIO interrupts only for the first
>  	 * 8 interrupts. The upper half (8-15) can only be used to trigger
>  	 * GPEs.
>  	 */
> -- 
> 2.7.4

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] Drivers: pinctrl: intel fixed typo Chris Gorman <chrisjohgorman@gmail.com> - 2017-09-25 20:50 +0200
  Re: [PATCH] Drivers: pinctrl: intel fixed typo Mika Westerberg <mika.westerberg@linux.intel.com> - 2017-09-26 08:50 +0200

csiph-web