Re: [PATCH] mm: fix RODATA_TEST failure "rodata_test: test data was not read only"

From	Segher Boessenkool <segher@kernel.crashing.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] mm: fix RODATA_TEST failure "rodata_test: test data was not read only"
Date	2017-09-25 21:50 +0200
Message-ID	<utHya-2oD-17@gated-at.bofh.it> (permalink)
References	<us67D-7vA-3@gated-at.bofh.it> <utkBz-49N-1@gated-at.bofh.it> <utw9I-3eX-11@gated-at.bofh.it> <utE7g-fi-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Sep 25, 2017 at 04:01:55PM +0000, David Laight wrote:
> From: Segher Boessenkool
> > The compiler puts this item in .sdata, for 32-bit.  There is no .srodata,
> > so if it wants to use a small data section, it must use .sdata .
> > 
> > Non-external, non-referenced symbols are not put in .sdata, that is the
> > difference you see with the "static".
> > 
> > I don't think there is a bug here.  If you think there is, please open
> > a GCC bug.
> 
> The .sxxx sections are for 'small' data that can be accessed (typically)
> using small offsets from a global register.
> This means that all sections must be adjacent in the image.
> So you can't really have readonly small data.
> 
> My guess is that the linker script is putting .srodata in with .sdata.

.srodata does not *exist* (in the ABI).


Segher

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] mm: fix RODATA_TEST failure "rodata_test: test data was not read only" Christophe Leroy <christophe.leroy@c-s.fr> - 2017-09-21 11:40 +0200
  Re: [PATCH] mm: fix RODATA_TEST failure "rodata_test: test data was  not read only" Kees Cook <keescook@chromium.org> - 2017-09-24 21:20 +0200
    Re: [PATCH] mm: fix RODATA_TEST failure "rodata_test: test data was not read only" Segher Boessenkool <segher@kernel.crashing.org> - 2017-09-25 09:40 +0200
      RE: [PATCH] mm: fix RODATA_TEST failure "rodata_test: test data was  not read only" David Laight <David.Laight@ACULAB.COM> - 2017-09-25 18:10 +0200
        Re: [PATCH] mm: fix RODATA_TEST failure "rodata_test: test data was not read only" Segher Boessenkool <segher@kernel.crashing.org> - 2017-09-25 21:50 +0200

csiph-web