Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1739143

RE: [PATCH] mm: fix RODATA_TEST failure "rodata_test: test data was not read only"

Show all headers | View raw

From: Segher Boessenkool
> Sent: 25 September 2017 08:37
> On Sun, Sep 24, 2017 at 12:17:51PM -0700, Kees Cook wrote:
> > On Thu, Sep 21, 2017 at 2:37 AM, Christophe Leroy
> > <christophe.leroy@c-s.fr> wrote:
> > > On powerpc, RODATA_TEST fails with message the following messages:
> > >
> > > [    6.199505] Freeing unused kernel memory: 528K
> > > [    6.203935] rodata_test: test data was not read only
> > >
> > > This is because GCC allocates it to .data section:
> > >
> > > c0695034 g     O .data  00000004 rodata_test_data
> >
> > Uuuh... that seems like a compiler bug. It's marked "const" -- it
> > should never end up in .data. I would argue that this has done exactly
> > what it was supposed to do, and shows that something has gone wrong.
> > It should always be const. Adding "static" should just change
> > visibility. (I'm not opposed to the static change, but it seems to
> > paper over a problem with the compiler...)
> 
> The compiler puts this item in .sdata, for 32-bit.  There is no .srodata,
> so if it wants to use a small data section, it must use .sdata .
> 
> Non-external, non-referenced symbols are not put in .sdata, that is the
> difference you see with the "static".
> 
> I don't think there is a bug here.  If you think there is, please open
> a GCC bug.

The .sxxx sections are for 'small' data that can be accessed (typically)
using small offsets from a global register.
This means that all sections must be adjacent in the image.
So you can't really have readonly small data.

My guess is that the linker script is putting .srodata in with .sdata.

	David

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] mm: fix RODATA_TEST failure "rodata_test: test data was not read only" Christophe Leroy <christophe.leroy@c-s.fr> - 2017-09-21 11:40 +0200
  Re: [PATCH] mm: fix RODATA_TEST failure "rodata_test: test data was  not read only" Kees Cook <keescook@chromium.org> - 2017-09-24 21:20 +0200
    Re: [PATCH] mm: fix RODATA_TEST failure "rodata_test: test data was not read only" Segher Boessenkool <segher@kernel.crashing.org> - 2017-09-25 09:40 +0200
      RE: [PATCH] mm: fix RODATA_TEST failure "rodata_test: test data was  not read only" David Laight <David.Laight@ACULAB.COM> - 2017-09-25 18:10 +0200
        Re: [PATCH] mm: fix RODATA_TEST failure "rodata_test: test data was not read only" Segher Boessenkool <segher@kernel.crashing.org> - 2017-09-25 21:50 +0200

csiph-web