Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1736493

[PATCH] mm: fix RODATA_TEST failure "rodata_test: test data was not read only"

Show all headers | View raw

On powerpc, RODATA_TEST fails with message the following messages:

[    6.199505] Freeing unused kernel memory: 528K
[    6.203935] rodata_test: test data was not read only

This is because GCC allocates it to .data section:

c0695034 g     O .data	00000004 rodata_test_data

Since commit 056b9d8a76924 ("mm: remove rodata_test_data export,
add pr_fmt"), rodata_test_data is used only inside rodata_test.c
By declaring it static, it gets properly allocated into .rodata
section instead of .data:

c04df710 l     O .rodata	00000004 rodata_test_data

Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
---
 mm/rodata_test.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/rodata_test.c b/mm/rodata_test.c
index 6bb4deb12e78..d908c8769b48 100644
--- a/mm/rodata_test.c
+++ b/mm/rodata_test.c
@@ -14,7 +14,7 @@
 #include <linux/uaccess.h>
 #include <asm/sections.h>
 
-const int rodata_test_data = 0xC3;
+static const int rodata_test_data = 0xC3;
 
 void rodata_test(void)
 {
-- 
2.13.3

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] mm: fix RODATA_TEST failure "rodata_test: test data was not read only" Christophe Leroy <christophe.leroy@c-s.fr> - 2017-09-21 11:40 +0200
  Re: [PATCH] mm: fix RODATA_TEST failure "rodata_test: test data was  not read only" Kees Cook <keescook@chromium.org> - 2017-09-24 21:20 +0200
    Re: [PATCH] mm: fix RODATA_TEST failure "rodata_test: test data was not read only" Segher Boessenkool <segher@kernel.crashing.org> - 2017-09-25 09:40 +0200
      RE: [PATCH] mm: fix RODATA_TEST failure "rodata_test: test data was  not read only" David Laight <David.Laight@ACULAB.COM> - 2017-09-25 18:10 +0200
        Re: [PATCH] mm: fix RODATA_TEST failure "rodata_test: test data was not read only" Segher Boessenkool <segher@kernel.crashing.org> - 2017-09-25 21:50 +0200

csiph-web