Re: [PATCH] pinctrl: single: make two arrays static const, reduces object code size

From	Linus Walleij <linus.walleij@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] pinctrl: single: make two arrays static const, reduces object code size
Date	2017-09-21 14:20 +0200
Message-ID	<us8Cu-Sx-11@gated-at.bofh.it> (permalink)
References	<urs0x-6GG-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Sep 19, 2017 at 4:42 PM, Colin King <colin.king@canonical.com> wrote:

> From: Colin Ian King <colin.king@canonical.com>
>
> Don't populate the read-only arrays prop2 and prop4 on the stack, instead
> make them static const.  Makes the object code smaller by over 230 bytes:
>
> Before:
>    text    data     bss     dec     hex filename
>   28235    5820     192   34247    85c7 drivers/pinctrl/pinctrl-single.o
>
> After:
>    text    data     bss     dec     hex filename
>   27839    5980     192   34011    84db drivers/pinctrl/pinctrl-single.o
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Patch applied with Tony's ACK.

Yours,
Linus Walleij

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] pinctrl: single: make two arrays static const, reduces object code size Colin King <colin.king@canonical.com> - 2017-09-19 16:50 +0200
  Re: [PATCH] pinctrl: single: make two arrays static const, reduces  object code size Tony Lindgren <tony@atomide.com> - 2017-09-19 18:30 +0200
  Re: [PATCH] pinctrl: single: make two arrays static const, reduces  object code size Linus Walleij <linus.walleij@linaro.org> - 2017-09-21 14:20 +0200

csiph-web