Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1736611

Re: [PATCH] pinctrl: bcm2835: fix build warning in bcm2835_gpio_irq_handle_bank

Show all headers | View raw

On Tue, Sep 19, 2017 at 9:04 PM, Corentin Labbe
<clabbe.montjoie@gmail.com> wrote:

> This patch fix the following build warning:
> drivers/pinctrl/bcm/pinctrl-bcm2835.c:376:15: warning: variable 'type' set but not used [-Wunused-but-set-variable]
>
> Furthermore, it is unused for a long time, at least since commit 85ae9e512f43 ("pinctrl: bcm2835: switch to GPIOLIB_IRQCHIP")
> where a "FIXME no clue why the code looks up the type here" was added.
> A year after, nobody answeered this question, so its time to remove it.
>
> Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>

Patch applied with Stefan's ACK.

Yours,
Linus Walleij

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] pinctrl: bcm2835: fix build warning in bcm2835_gpio_irq_handle_bank Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-09-19 21:10 +0200
  Re: [PATCH] pinctrl: bcm2835: fix build warning in  bcm2835_gpio_irq_handle_bank Stefan Wahren <stefan.wahren@i2se.com> - 2017-09-20 09:10 +0200
  Re: [PATCH] pinctrl: bcm2835: fix build warning in bcm2835_gpio_irq_handle_bank Linus Walleij <linus.walleij@linaro.org> - 2017-09-21 14:20 +0200

csiph-web