Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1734970 > unrolled thread
| Started by | Colin King <colin.king@canonical.com> |
|---|---|
| First post | 2017-09-19 16:50 +0200 |
| Last post | 2017-09-21 14:20 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] pinctrl: single: make two arrays static const, reduces object code size Colin King <colin.king@canonical.com> - 2017-09-19 16:50 +0200
Re: [PATCH] pinctrl: single: make two arrays static const, reduces object code size Tony Lindgren <tony@atomide.com> - 2017-09-19 18:30 +0200
Re: [PATCH] pinctrl: single: make two arrays static const, reduces object code size Linus Walleij <linus.walleij@linaro.org> - 2017-09-21 14:20 +0200
| From | Colin King <colin.king@canonical.com> |
|---|---|
| Date | 2017-09-19 16:50 +0200 |
| Subject | [PATCH] pinctrl: single: make two arrays static const, reduces object code size |
| Message-ID | <urs0x-6GG-9@gated-at.bofh.it> |
From: Colin Ian King <colin.king@canonical.com>
Don't populate the read-only arrays prop2 and prop4 on the stack, instead
make them static const. Makes the object code smaller by over 230 bytes:
Before:
text data bss dec hex filename
28235 5820 192 34247 85c7 drivers/pinctrl/pinctrl-single.o
After:
text data bss dec hex filename
27839 5980 192 34011 84db drivers/pinctrl/pinctrl-single.o
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/pinctrl/pinctrl-single.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pinctrl/pinctrl-single.c b/drivers/pinctrl/pinctrl-single.c
index b8b3d932cd73..e6cd8de793e2 100644
--- a/drivers/pinctrl/pinctrl-single.c
+++ b/drivers/pinctrl/pinctrl-single.c
@@ -873,13 +873,13 @@ static int pcs_parse_pinconf(struct pcs_device *pcs, struct device_node *np,
int i = 0, nconfs = 0;
unsigned long *settings = NULL, *s = NULL;
struct pcs_conf_vals *conf = NULL;
- struct pcs_conf_type prop2[] = {
+ static const struct pcs_conf_type prop2[] = {
{ "pinctrl-single,drive-strength", PIN_CONFIG_DRIVE_STRENGTH, },
{ "pinctrl-single,slew-rate", PIN_CONFIG_SLEW_RATE, },
{ "pinctrl-single,input-schmitt", PIN_CONFIG_INPUT_SCHMITT, },
{ "pinctrl-single,low-power-mode", PIN_CONFIG_LOW_POWER_MODE, },
};
- struct pcs_conf_type prop4[] = {
+ static const struct pcs_conf_type prop4[] = {
{ "pinctrl-single,bias-pullup", PIN_CONFIG_BIAS_PULL_UP, },
{ "pinctrl-single,bias-pulldown", PIN_CONFIG_BIAS_PULL_DOWN, },
{ "pinctrl-single,input-schmitt-enable",
--
2.14.1
[toc] | [next] | [standalone]
| From | Tony Lindgren <tony@atomide.com> |
|---|---|
| Date | 2017-09-19 18:30 +0200 |
| Subject | Re: [PATCH] pinctrl: single: make two arrays static const, reduces object code size |
| Message-ID | <urtzk-7ID-13@gated-at.bofh.it> |
| In reply to | #1734970 |
* Colin King <colin.king@canonical.com> [170919 07:43]:
> From: Colin Ian King <colin.king@canonical.com>
>
> Don't populate the read-only arrays prop2 and prop4 on the stack, instead
> make them static const. Makes the object code smaller by over 230 bytes:
>
> Before:
> text data bss dec hex filename
> 28235 5820 192 34247 85c7 drivers/pinctrl/pinctrl-single.o
>
> After:
> text data bss dec hex filename
> 27839 5980 192 34011 84db drivers/pinctrl/pinctrl-single.o
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Tony Lindgren <tony@atomide.com>
> ---
> drivers/pinctrl/pinctrl-single.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pinctrl/pinctrl-single.c b/drivers/pinctrl/pinctrl-single.c
> index b8b3d932cd73..e6cd8de793e2 100644
> --- a/drivers/pinctrl/pinctrl-single.c
> +++ b/drivers/pinctrl/pinctrl-single.c
> @@ -873,13 +873,13 @@ static int pcs_parse_pinconf(struct pcs_device *pcs, struct device_node *np,
> int i = 0, nconfs = 0;
> unsigned long *settings = NULL, *s = NULL;
> struct pcs_conf_vals *conf = NULL;
> - struct pcs_conf_type prop2[] = {
> + static const struct pcs_conf_type prop2[] = {
> { "pinctrl-single,drive-strength", PIN_CONFIG_DRIVE_STRENGTH, },
> { "pinctrl-single,slew-rate", PIN_CONFIG_SLEW_RATE, },
> { "pinctrl-single,input-schmitt", PIN_CONFIG_INPUT_SCHMITT, },
> { "pinctrl-single,low-power-mode", PIN_CONFIG_LOW_POWER_MODE, },
> };
> - struct pcs_conf_type prop4[] = {
> + static const struct pcs_conf_type prop4[] = {
> { "pinctrl-single,bias-pullup", PIN_CONFIG_BIAS_PULL_UP, },
> { "pinctrl-single,bias-pulldown", PIN_CONFIG_BIAS_PULL_DOWN, },
> { "pinctrl-single,input-schmitt-enable",
> --
> 2.14.1
>
[toc] | [prev] | [next] | [standalone]
| From | Linus Walleij <linus.walleij@linaro.org> |
|---|---|
| Date | 2017-09-21 14:20 +0200 |
| Subject | Re: [PATCH] pinctrl: single: make two arrays static const, reduces object code size |
| Message-ID | <us8Cu-Sx-11@gated-at.bofh.it> |
| In reply to | #1734970 |
On Tue, Sep 19, 2017 at 4:42 PM, Colin King <colin.king@canonical.com> wrote: > From: Colin Ian King <colin.king@canonical.com> > > Don't populate the read-only arrays prop2 and prop4 on the stack, instead > make them static const. Makes the object code smaller by over 230 bytes: > > Before: > text data bss dec hex filename > 28235 5820 192 34247 85c7 drivers/pinctrl/pinctrl-single.o > > After: > text data bss dec hex filename > 27839 5980 192 34011 84db drivers/pinctrl/pinctrl-single.o > > Signed-off-by: Colin Ian King <colin.king@canonical.com> Patch applied with Tony's ACK. Yours, Linus Walleij
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web