Re: [PATCH] tcp: avoid bogus warning in tcp_clean_rtx_queue

Path	csiph.com!news.redatomik.org!fu-berlin.de!bofh.it!news.nic.it!robomod
From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH] tcp: avoid bogus warning in tcp_clean_rtx_queue
Date	Wed, 20 Sep 2017 00:10:01 +0200
Message-ID	<urySl-2Ga-5@gated-at.bofh.it> (permalink)
References	<urb9o-2X2-7@gated-at.bofh.it> <urxWh-251-5@gated-at.bofh.it> <urypk-2ht-33@gated-at.bofh.it>
X-Mailer	Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO)
MIME-Version	1.0
Content-Type	Text/Plain; charset=us-ascii
Content-Transfer-Encoding	7bit
X-Greylist	Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 19 Sep 2017 15:01:47 -0700 (PDT)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	16
Organization	linux.* mail to news gateway
X-Original-Cc	kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org, edumazet@google.com, ncardwell@google.com, ycheng@google.com, soheil@google.com, fw@strlen.de, netdev@vger.kernel.org, linux-kernel@vger.kernel.org
X-Original-Date	Tue, 19 Sep 2017 15:01:46 -0700 (PDT)
X-Original-Message-ID	<20170919.150146.960352165896854483.davem@davemloft.net>
X-Original-References	<20170918204855.170920-1-arnd@arndb.de> <20170919.140250.1393293793761020505.davem@davemloft.net> <CAK8P3a3G78pqFsoimeNrKnPLOUYR+X1qzhbKyabn_tN4oZMLyQ@mail.gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1735292

Show key headers only | View raw

From: Arnd Bergmann <arnd@arndb.de>
Date: Tue, 19 Sep 2017 23:32:33 +0200

> On Tue, Sep 19, 2017 at 11:02 PM, David Miller <davem@davemloft.net> wrote:
>> What cpu did you test the object code generation upon and does that
>> cpu have branch prediction hints in the target you are building for?
> 
> This was a randconfig build targetting ARMv5. I'm pretty sure that has
> no such hint instructions.

I just tested on sparc64 and it changed the branch prediction:

 .L2157:
-       brz,pn  %i3, .L1898     ! first_ackt,
+       brz,pt  %i2, .L1898     ! first_ackt,
         mov    -1, %o2 !, seq_rtt_us

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] tcp: avoid bogus warning in tcp_clean_rtx_queue Arnd Bergmann <arnd@arndb.de> - 2017-09-18 22:50 +0200
  Re: [PATCH] tcp: avoid bogus warning in tcp_clean_rtx_queue David Miller <davem@davemloft.net> - 2017-09-19 23:10 +0200
    Re: [PATCH] tcp: avoid bogus warning in tcp_clean_rtx_queue Arnd Bergmann <arnd@arndb.de> - 2017-09-19 23:40 +0200
      Re: [PATCH] tcp: avoid bogus warning in tcp_clean_rtx_queue David Miller <davem@davemloft.net> - 2017-09-20 00:10 +0200

csiph-web