Re: [PATCH] tcp: avoid bogus warning in tcp_clean_rtx_queue

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH] tcp: avoid bogus warning in tcp_clean_rtx_queue
Date	2017-09-20 00:10 +0200
Message-ID	<urySl-2Ga-5@gated-at.bofh.it> (permalink)
References	<urb9o-2X2-7@gated-at.bofh.it> <urxWh-251-5@gated-at.bofh.it> <urypk-2ht-33@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Arnd Bergmann <arnd@arndb.de>
Date: Tue, 19 Sep 2017 23:32:33 +0200

> On Tue, Sep 19, 2017 at 11:02 PM, David Miller <davem@davemloft.net> wrote:
>> What cpu did you test the object code generation upon and does that
>> cpu have branch prediction hints in the target you are building for?
> 
> This was a randconfig build targetting ARMv5. I'm pretty sure that has
> no such hint instructions.

I just tested on sparc64 and it changed the branch prediction:

 .L2157:
-       brz,pn  %i3, .L1898     ! first_ackt,
+       brz,pt  %i2, .L1898     ! first_ackt,
         mov    -1, %o2 !, seq_rtt_us

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] tcp: avoid bogus warning in tcp_clean_rtx_queue Arnd Bergmann <arnd@arndb.de> - 2017-09-18 22:50 +0200
  Re: [PATCH] tcp: avoid bogus warning in tcp_clean_rtx_queue David Miller <davem@davemloft.net> - 2017-09-19 23:10 +0200
    Re: [PATCH] tcp: avoid bogus warning in tcp_clean_rtx_queue Arnd Bergmann <arnd@arndb.de> - 2017-09-19 23:40 +0200
      Re: [PATCH] tcp: avoid bogus warning in tcp_clean_rtx_queue David Miller <davem@davemloft.net> - 2017-09-20 00:10 +0200

csiph-web