Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1735266

Re: [PATCH] tcp: avoid bogus warning in tcp_clean_rtx_queue

Show all headers | View raw

From: Arnd Bergmann <arnd@arndb.de>
Date: Mon, 18 Sep 2017 22:48:47 +0200

> gcc-4.9 warns that it cannot trace the state of the 'last_ackt'
> variable since the change to the TCP timestamping code, when
> CONFIG_PROFILE_ANNOTATED_BRANCHES is set:
> 
> net/ipv4/tcp_input.c: In function 'tcp_clean_rtx_queue':
> include/net/tcp.h:757:23: error: 'last_ackt' may be used uninitialized in this function [-Werror=maybe-uninitialized]
> 
> Other gcc versions, both older and newer do now show this
> warning. Removing the 'likely' annotation makes it go away,
> and has no effect on the object code without
> CONFIG_PROFILE_ANNOTATED_BRANCHES, as tested with gcc-4.9
> and gcc-7.1.1, so this seems to be a safe workaround.
> 
> Fixes: 9a568de4818d ("tcp: switch TCP TS option (RFC 7323) to 1ms clock")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

This reaches the limits at which I am willing to work around compiler
stuff.

What cpu did you test the object code generation upon and does that
cpu have branch prediction hints in the target you are building for?

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] tcp: avoid bogus warning in tcp_clean_rtx_queue Arnd Bergmann <arnd@arndb.de> - 2017-09-18 22:50 +0200
  Re: [PATCH] tcp: avoid bogus warning in tcp_clean_rtx_queue David Miller <davem@davemloft.net> - 2017-09-19 23:10 +0200
    Re: [PATCH] tcp: avoid bogus warning in tcp_clean_rtx_queue Arnd Bergmann <arnd@arndb.de> - 2017-09-19 23:40 +0200
      Re: [PATCH] tcp: avoid bogus warning in tcp_clean_rtx_queue David Miller <davem@davemloft.net> - 2017-09-20 00:10 +0200

csiph-web