Re: [PATCH v2] ipv4: Namespaceify tcp_fastopen knob

Path	csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Eric Dumazet <eric.dumazet@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] ipv4: Namespaceify tcp_fastopen knob
Date	Wed, 13 Sep 2017 15:10:01 +0200
Message-ID	<upfAt-7M6-3@gated-at.bofh.it> (permalink)
References	<upe1I-6JZ-11@gated-at.bofh.it> <upfh7-7ps-3@gated-at.bofh.it>
X-Original-To	Haishuang Yan <yanhaishuang@cmss.chinamobile.com>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=message-id:subject:from:to:cc:date:in-reply-to:references :mime-version:content-transfer-encoding; bh=Q7i+hjhY/XcLDBfUXqbqYhavWzHYB0GmMm+5MJkOrCQ=; b=DWVNmBSZcpwjHmzHxAvML8oelvUX1IJ7Jxo8073cwNNKBpeZYncv7+pBk2a81Lfhwk ZiSQ/qX6sUbR3Z3oWEJ5x4YWchjhcJ8/6xKP55V77ecTYv5Fv8tdeLjlb4vUH52mfgIr 79hgxrT1Y9pzKHg11Oz0U71JvkrlxW8bZFI2ug2ylMJXIPeAGYk0J9q/NVn/k43h2rog ObwTW8clonsmMfKpO/kdd2eUpFZI88SEVlwL8VxupwVu35Yo7aM3m4/V75CD6W6Nu3LY 49UQcDkb0dWVJL3C8tjHz4tQUz92UFQQdIjJ5yfnroTrEHNJHYjr9AVM7g9PXj7wcTUQ NiQQ==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:mime-version:content-transfer-encoding; bh=Q7i+hjhY/XcLDBfUXqbqYhavWzHYB0GmMm+5MJkOrCQ=; b=KhjC4QdemO6DvKjEizMHwOcdIG6uhlxfqorZskpJAaPFTI70++hsfqI7hQWfs72yrX NRmAbLCTRL1vzOSyQK0VVF69GaPC4HVko7qljE9c6SvNbPulV9drWO41rx5525lwp2xg +zXoslrRuEmkSzlhl9TFR9ltTW8j8c8ink3hneAbeMaCC4rV3uK2t+QQqoBHQ6gGh5Bi ChSslNeUk7kUmgo3/BGbi9fuY8xmmdx3ZPvKa0kDMaIhuJ0w4KtP9WM6sCOKBswvVSim huwGjlFLGV30aMNSlVZG0CrrdA5k9qJWgakhYSioJy9EbwWXgi4fjsJZdFlU433CJKcE OwBw==
X-Gm-Message-State	AHPjjUjTccHecovyZUmJs0SqCWOoWqx2vOzzCDSKSbJYdrQJH4yIdr3H 4tSly4feJVXRY8NM5Avl+1Y=
X-Google-SMTP-Source	AOwi7QAnDS0o/trfY8DdgTEchXbcM3dJBwldL8hAm0/cEVYz/50z2SMkYwk2trjc6H10s5Zx8Tx3Sw==
X-Received	by 10.36.95.10 with SMTP id r10mr4147150itb.73.1505307781774; Wed, 13 Sep 2017 06:03:01 -0700 (PDT)
Content-Type	text/plain; charset="UTF-8"
X-Mailer	Evolution 3.10.4-0ubuntu2
MIME-Version	1.0
Content-Transfer-Encoding	7bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	19
Organization	linux.* mail to news gateway
X-Original-Cc	"David S. Miller" <davem@davemloft.net>, Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>, Eric Dumazet <edumazet@google.com>, Luca BRUNO <lucab@debian.org>, netdev@vger.kernel.org, linux-kernel@vger.kernel.org
X-Original-Date	Wed, 13 Sep 2017 06:02:59 -0700
X-Original-Message-ID	<1505307779.15310.157.camel@edumazet-glaptop3.roam.corp.google.com>
X-Original-References	<1505301598-12681-1-git-send-email-yanhaishuang@cmss.chinamobile.com> <1505306674.15310.155.camel@edumazet-glaptop3.roam.corp.google.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1731596

Show key headers only | View raw

On Wed, 2017-09-13 at 05:44 -0700, Eric Dumazet wrote:
> On Wed, 2017-09-13 at 19:19 +0800, Haishuang Yan wrote:
> > Different namespace application might require enable TCP Fast Open
> > feature independently of the host.
> > 
> 
> Poor changelog, no actual description / list of sysctls that are moved
> to per netns.
> 
> And looking at the patch, it seems your conversion is not complete.
> 
> So I will ask you to provide more evidence that you tested your patch
> next time you submit it.

I suggest you move one sysctl at a time, in a patch series.

It will be easier to document and test for you, and review for us.

Thanks.

Thread

[PATCH v2] ipv4: Namespaceify tcp_fastopen knob Haishuang Yan <yanhaishuang@cmss.chinamobile.com> - 2017-09-13 13:30 +0200
  Re: [PATCH v2] ipv4: Namespaceify tcp_fastopen knob Eric Dumazet <eric.dumazet@gmail.com> - 2017-09-13 14:50 +0200
    Re: [PATCH v2] ipv4: Namespaceify tcp_fastopen knob Eric Dumazet <eric.dumazet@gmail.com> - 2017-09-13 15:10 +0200
      Re: [PATCH v2] ipv4: Namespaceify tcp_fastopen knob 严海双 <yanhaishuang@cmss.chinamobile.com> - 2017-09-14 08:20 +0200

csiph-web