Groups > linux.kernel > #1732058

Re: [PATCH v2] ipv4: Namespaceify tcp_fastopen knob

From	严海双 <yanhaishuang@cmss.chinamobile.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] ipv4: Namespaceify tcp_fastopen knob
Date	2017-09-14 08:20 +0200
Message-ID	<upvFf-1oE-5@gated-at.bofh.it> (permalink)
References	<upe1I-6JZ-11@gated-at.bofh.it> <upfh7-7ps-3@gated-at.bofh.it> <upfAt-7M6-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


> On 2017年9月13日, at 下午9:02, Eric Dumazet <eric.dumazet@gmail.com> wrote:
> 
> On Wed, 2017-09-13 at 05:44 -0700, Eric Dumazet wrote:
>> On Wed, 2017-09-13 at 19:19 +0800, Haishuang Yan wrote:
>>> Different namespace application might require enable TCP Fast Open
>>> feature independently of the host.
>>> 
>> 
>> Poor changelog, no actual description / list of sysctls that are moved
>> to per netns.
>> 
>> And looking at the patch, it seems your conversion is not complete.
>> 
>> So I will ask you to provide more evidence that you tested your patch
>> next time you submit it.
> 
> I suggest you move one sysctl at a time, in a patch series.
> 
> It will be easier to document and test for you, and review for us.
> 
> Thanks.
> 

Okay, I will split my patch for each sysctl change. Thanks.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2] ipv4: Namespaceify tcp_fastopen knob Haishuang Yan <yanhaishuang@cmss.chinamobile.com> - 2017-09-13 13:30 +0200
  Re: [PATCH v2] ipv4: Namespaceify tcp_fastopen knob Eric Dumazet <eric.dumazet@gmail.com> - 2017-09-13 14:50 +0200
    Re: [PATCH v2] ipv4: Namespaceify tcp_fastopen knob Eric Dumazet <eric.dumazet@gmail.com> - 2017-09-13 15:10 +0200
      Re: [PATCH v2] ipv4: Namespaceify tcp_fastopen knob 严海双 <yanhaishuang@cmss.chinamobile.com> - 2017-09-14 08:20 +0200

csiph-web