Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1731597
| From | Allen <allen.lkml@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 06/10] drivers:ethernet: return -ENOMEM on allocation failure. |
| Date | 2017-09-13 15:10 +0200 |
| Message-ID | <upfAt-7M6-5@gated-at.bofh.it> (permalink) |
| References | <upar7-4lj-1@gated-at.bofh.it> <upar9-4lj-45@gated-at.bofh.it> <upeO6-7fC-17@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
>
> static int cas_alloc_rxds(struct cas *cp)
> {
> int i;
>
> for (i = 0; i < N_RX_DESC_RINGS; i++) {
> if (cas_alloc_rx_desc(cp, i) < 0) {
> cas_free_rxds(cp);
> return -1;
> }
> }
> return 0;
> }
>
> Again, your change is correct, but in the end the value is not used.
> And if you fix it at the cas_alloc_rxds level, you also need a fix at
> the next level up:
>
> err = -ENOMEM;
> if (cas_tx_tiny_alloc(cp) < 0)
> goto err_unlock;
>
> /* alloc rx descriptors */
> if (cas_alloc_rxds(cp) < 0)
> goto err_tx_tiny;
>
> again, the return value is discarded.
I agree. I could send out v2 with fixes at both level.
- Allen
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 01/10] arch:powerpc: return -ENOMEM on failed allocation Allen Pais <allen.lkml@gmail.com> - 2017-09-13 09:40 +0200
[PATCH 02/10] drivers:crypto: return -ENOMEM on allocation failure. Allen Pais <allen.lkml@gmail.com> - 2017-09-13 09:40 +0200
[PATCH 08/10] driver:cxgbit: return -NOMEM on allocation failure. Allen Pais <allen.lkml@gmail.com> - 2017-09-13 09:40 +0200
[PATCH 03/10] driver:gpu: return -ENOMEM on allocation failure. Allen Pais <allen.lkml@gmail.com> - 2017-09-13 09:40 +0200
[PATCH 04/10] drivers:mpt: return -ENOMEM on allocation failure. Allen Pais <allen.lkml@gmail.com> - 2017-09-13 09:40 +0200
[PATCH 10/10] fs:btrfs: return -ENOMEM on allocation failure. Allen Pais <allen.lkml@gmail.com> - 2017-09-13 09:40 +0200
Re: [PATCH 10/10] fs:btrfs: return -ENOMEM on allocation failure. David Sterba <dsterba@suse.cz> - 2017-09-13 17:20 +0200
[PATCH 09/10] driver:video: return -ENOMEM on allocation failure. Allen Pais <allen.lkml@gmail.com> - 2017-09-13 09:40 +0200
[PATCH 05/10] drivers:net: return -ENOMEM on allocation failure. Allen Pais <allen.lkml@gmail.com> - 2017-09-13 09:40 +0200
Re: [PATCH 05/10] drivers:net: return -ENOMEM on allocation failure. Andrew Lunn <andrew@lunn.ch> - 2017-09-13 14:10 +0200
Re: [PATCH 05/10] drivers:net: return -ENOMEM on allocation failure. Allen <allen.lkml@gmail.com> - 2017-09-13 15:10 +0200
Re: [PATCH 05/10] drivers:net: return -ENOMEM on allocation failure. Allen <allen.lkml@gmail.com> - 2017-09-20 09:20 +0200
[PATCH 07/10] driver:megaraid: return -ENOMEM on allocation failure. Allen Pais <allen.lkml@gmail.com> - 2017-09-13 09:40 +0200
[PATCH 06/10] drivers:ethernet: return -ENOMEM on allocation failure. Allen Pais <allen.lkml@gmail.com> - 2017-09-13 09:40 +0200
Re: [PATCH 06/10] drivers:ethernet: return -ENOMEM on allocation failure. Andrew Lunn <andrew@lunn.ch> - 2017-09-13 14:20 +0200
Re: [PATCH 06/10] drivers:ethernet: return -ENOMEM on allocation failure. Allen <allen.lkml@gmail.com> - 2017-09-13 15:10 +0200
Re: [PATCH 06/10] drivers:ethernet: return -ENOMEM on allocation failure. Allen <allen.lkml@gmail.com> - 2017-09-20 09:00 +0200
Re: [PATCH 06/10] drivers:ethernet: return -ENOMEM on allocation failure. David Miller <davem@davemloft.net> - 2017-09-13 18:30 +0200
Re: [PATCH 01/10] arch:powerpc: return -ENOMEM on failed allocation Joe Perches <joe@perches.com> - 2017-09-13 17:00 +0200
Re: [PATCH 01/10] arch:powerpc: return -ENOMEM on failed allocation Allen <allen.lkml@gmail.com> - 2017-09-14 06:50 +0200
csiph-web