Re: [f2fs-dev] [PATCH] f2fs: fix double count on issued discard commands

From	Daeho Jeong <daeho.jeong@samsung.com>
Newsgroups	linux.kernel
Subject	Re: [f2fs-dev] [PATCH] f2fs: fix double count on issued discard commands
Date	2017-09-13 10:50 +0200
Message-ID	<upbwS-50A-13@gated-at.bofh.it> (permalink)
References	(3 earlier) <uoIEy-31E-7@gated-at.bofh.it> <uoKwG-4jB-1@gated-at.bofh.it> <uoL9n-4Vo-1@gated-at.bofh.it> <upbwS-50A-15@gated-at.bofh.it> <upa7L-4ev-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> Actually, we didn't change priority of discard command, so that it is still
> synchronous IO for I/O scheduler, hence I/O interference will still exist if we
> try to issue discard without IO aware ability.
 
> Of course we can change the priority of discard command to lower, but potential
> issue is that with ROW I/O scheduler in kernel or FTL, async I/O will handle
> very slowly in heavy load scenario, if we are going to trigger sync write IO in
> place in where we're doing async discard, we will face long latency.
 
> Still I think it is worth to build the ability to issue async discard as a part
> of discard policy and later we can adjust policy based on different scenario.
 
> Thanks,

Oh, I see.

f2fs is sending discard requests as "sync" requests, I didn't know that.
Right, I just though in case of CFQ I/O scheduler, but f2fs has to consider the other
schedulers, but CFQ.

Thanks, :)

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] f2fs: fix double count on issued discard commands Jaegeuk Kim <jaegeuk@kernel.org> - 2017-09-11 05:40 +0200
  Re: [f2fs-dev] [PATCH] f2fs: fix double count on issued discard  commands Chao Yu <yuchao0@huawei.com> - 2017-09-12 04:00 +0200
    Re: [f2fs-dev] [PATCH] f2fs: fix double count on issued discard  commands Chao Yu <yuchao0@huawei.com> - 2017-09-12 06:00 +0200
      Re: [f2fs-dev] [PATCH] f2fs: fix double count on issued discard  commands Jaegeuk Kim <jaegeuk@kernel.org> - 2017-09-12 06:30 +0200
        Re: [f2fs-dev] [PATCH] f2fs: fix double count on issued discard  commands Daeho Jeong <daeho.jeong@samsung.com> - 2017-09-12 06:40 +0200
          Re: [f2fs-dev] [PATCH] f2fs: fix double count on issued discard  commands Jaegeuk Kim <jaegeuk@kernel.org> - 2017-09-12 19:20 +0200
          Re: [f2fs-dev] [PATCH] f2fs: fix double count on issued discard  commands Chao Yu <yuchao0@huawei.com> - 2017-09-13 09:20 +0200
            Re: [f2fs-dev] [PATCH] f2fs: fix double count on issued discard  commands Daeho Jeong <daeho.jeong@samsung.com> - 2017-09-13 10:50 +0200

csiph-web