Re: [f2fs-dev] [PATCH] f2fs: fix double count on issued discard commands

From	Jaegeuk Kim <jaegeuk@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [f2fs-dev] [PATCH] f2fs: fix double count on issued discard commands
Date	2017-09-12 06:30 +0200
Message-ID	<uoKZI-4Sv-9@gated-at.bofh.it> (permalink)
References	<uonJL-5sB-7@gated-at.bofh.it> <uoIEy-31E-7@gated-at.bofh.it> <uoKwG-4jB-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 09/12, Chao Yu wrote:
> On 2017/9/12 9:53, Chao Yu wrote:
> > On 2017/9/11 11:38, Jaegeuk Kim wrote:
> >> If issue_cond is true, it does double count for # of issued commands.
> >>
> >> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
> > 
> > Reviewed-by: Chao Yu <yuchao0@huawei.com>
> 
> As Daeho Jeong mentioned, the change makes 'iter > DISCARD_ISSUE_RATE' dead
> code, I just misread iter and issued variable, sorry. :(

Yeah, that's exactly like what I made a mistake before.
I should have mentioned that earlier. :)

> 
> Thanks,
> 
> > 
> >> ---
> >>  fs/f2fs/segment.c | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
> >> index 7fd742f747ce..25196ff5d587 100644
> >> --- a/fs/f2fs/segment.c
> >> +++ b/fs/f2fs/segment.c
> >> @@ -1087,7 +1087,7 @@ static int __issue_discard_cmd(struct f2fs_sb_info *sbi, bool issue_cond)
> >>  				issued++;
> >>  				__submit_discard_cmd(sbi, dc);
> >>  			}
> >> -			if (issue_cond && iter++ > DISCARD_ISSUE_RATE)
> >> +			if (issue_cond && iter > DISCARD_ISSUE_RATE)
> >>  				goto out;
> >>  		}
> >>  		if (list_empty(pend_list) && dcc->pend_list_tag[i] & P_TRIM)
> >>
> > 
> > 
> >

Thread

[PATCH] f2fs: fix double count on issued discard commands Jaegeuk Kim <jaegeuk@kernel.org> - 2017-09-11 05:40 +0200
  Re: [f2fs-dev] [PATCH] f2fs: fix double count on issued discard  commands Chao Yu <yuchao0@huawei.com> - 2017-09-12 04:00 +0200
    Re: [f2fs-dev] [PATCH] f2fs: fix double count on issued discard  commands Chao Yu <yuchao0@huawei.com> - 2017-09-12 06:00 +0200
      Re: [f2fs-dev] [PATCH] f2fs: fix double count on issued discard  commands Jaegeuk Kim <jaegeuk@kernel.org> - 2017-09-12 06:30 +0200
        Re: [f2fs-dev] [PATCH] f2fs: fix double count on issued discard  commands Daeho Jeong <daeho.jeong@samsung.com> - 2017-09-12 06:40 +0200
          Re: [f2fs-dev] [PATCH] f2fs: fix double count on issued discard  commands Jaegeuk Kim <jaegeuk@kernel.org> - 2017-09-12 19:20 +0200
          Re: [f2fs-dev] [PATCH] f2fs: fix double count on issued discard  commands Chao Yu <yuchao0@huawei.com> - 2017-09-13 09:20 +0200
            Re: [f2fs-dev] [PATCH] f2fs: fix double count on issued discard  commands Daeho Jeong <daeho.jeong@samsung.com> - 2017-09-13 10:50 +0200

csiph-web