Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1730416

Re: [Outreachy kernel] [PATCH] Staging: ccree: Don't use volatile for monitor_lock

Show all headers | View raw

On Mon, 11 Sep 2017, Srishti Sharma wrote:

> The use of volatile for the variable monitor_lock is unnecessary.

You need to give more evidence of why this is the case.  How is the
variable used?  I guess this comes from checkpatch, but checkpatch has
only a local view of things, and doesn't know how the variable is used.

julia

>
> Signed-off-by: Srishti Sharma <srishtishar@gmail.com>
> ---
>  drivers/staging/ccree/ssi_request_mgr.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/ccree/ssi_request_mgr.c b/drivers/staging/ccree/ssi_request_mgr.c
> index e5c2f92..7d77941 100644
> --- a/drivers/staging/ccree/ssi_request_mgr.c
> +++ b/drivers/staging/ccree/ssi_request_mgr.c
> @@ -49,7 +49,7 @@ struct ssi_request_mgr_handle {
>  	dma_addr_t dummy_comp_buff_dma;
>  	struct cc_hw_desc monitor_desc;
>
> -	volatile unsigned long monitor_lock;
> +	unsigned long monitor_lock;
>  #ifdef COMP_IN_WQ
>  	struct workqueue_struct *workq;
>  	struct delayed_work compwork;
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1505145571-11248-1-git-send-email-srishtishar%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] Staging: ccree: Don't use volatile for monitor_lock Srishti Sharma <srishtishar@gmail.com> - 2017-09-11 18:00 +0200
  Re: [PATCH] Staging: ccree: Don't use volatile for monitor_lock Srishti Sharma <srishtishar@gmail.com> - 2017-09-11 18:10 +0200
    Re: [Outreachy kernel] Re: [PATCH] Staging: ccree: Don't use volatile  for monitor_lock Sean Paul <seanpaul@chromium.org> - 2017-09-11 18:20 +0200
    Re: [Outreachy kernel] Re: [PATCH] Staging: ccree: Don't use volatile  for monitor_lock Julia Lawall <julia.lawall@lip6.fr> - 2017-09-11 18:20 +0200
      Re: [Outreachy kernel] Re: [PATCH] Staging: ccree: Don't use volatile  for monitor_lock Srishti Sharma <srishtishar@gmail.com> - 2017-09-11 18:20 +0200
        Re: [Outreachy kernel] Re: [PATCH] Staging: ccree: Don't use volatile  for monitor_lock Srishti Sharma <srishtishar@gmail.com> - 2017-09-11 18:40 +0200
  Re: [Outreachy kernel] [PATCH] Staging: ccree: Don't use volatile  for monitor_lock Julia Lawall <julia.lawall@lip6.fr> - 2017-09-11 18:10 +0200
  Re: [PATCH] Staging: ccree: Don't use volatile for monitor_lock Greg KH <gregkh@linuxfoundation.org> - 2017-09-11 18:10 +0200
  Re: [PATCH] Staging: ccree: Don't use volatile for monitor_lock Dan Carpenter <dan.carpenter@oracle.com> - 2017-09-12 11:30 +0200
    Re: [PATCH] Staging: ccree: Don't use volatile for monitor_lock Srishti Sharma <srishtishar@gmail.com> - 2017-09-12 14:10 +0200

csiph-web