Re: [PATCH] Staging: ccree: Don't use volatile for monitor_lock

From	Srishti Sharma <srishtishar@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] Staging: ccree: Don't use volatile for monitor_lock
Date	2017-09-12 14:10 +0200
Message-ID	<uoSaS-14j-3@gated-at.bofh.it> (permalink)
References	<uozhT-5lS-13@gated-at.bofh.it> <uoPG1-7Td-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Sep 12, 2017 at 2:49 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> On Mon, Sep 11, 2017 at 09:29:31PM +0530, Srishti Sharma wrote:
>> The use of volatile for the variable monitor_lock is unnecessary.
>>
>> Signed-off-by: Srishti Sharma <srishtishar@gmail.com>
>> ---
>>  drivers/staging/ccree/ssi_request_mgr.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/ccree/ssi_request_mgr.c b/drivers/staging/ccree/ssi_request_mgr.c
>> index e5c2f92..7d77941 100644
>> --- a/drivers/staging/ccree/ssi_request_mgr.c
>> +++ b/drivers/staging/ccree/ssi_request_mgr.c
>> @@ -49,7 +49,7 @@ struct ssi_request_mgr_handle {
>>       dma_addr_t dummy_comp_buff_dma;
>>       struct cc_hw_desc monitor_desc;
>>
>> -     volatile unsigned long monitor_lock;
>> +     unsigned long monitor_lock;
>
> The variable seems unused.  Try deleting it instead.

Had already sent a patch for that as v2.

Thanks
Srishti

> regards,
> dan carpenter
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] Staging: ccree: Don't use volatile for monitor_lock Srishti Sharma <srishtishar@gmail.com> - 2017-09-11 18:00 +0200
  Re: [PATCH] Staging: ccree: Don't use volatile for monitor_lock Srishti Sharma <srishtishar@gmail.com> - 2017-09-11 18:10 +0200
    Re: [Outreachy kernel] Re: [PATCH] Staging: ccree: Don't use volatile  for monitor_lock Sean Paul <seanpaul@chromium.org> - 2017-09-11 18:20 +0200
    Re: [Outreachy kernel] Re: [PATCH] Staging: ccree: Don't use volatile  for monitor_lock Julia Lawall <julia.lawall@lip6.fr> - 2017-09-11 18:20 +0200
      Re: [Outreachy kernel] Re: [PATCH] Staging: ccree: Don't use volatile  for monitor_lock Srishti Sharma <srishtishar@gmail.com> - 2017-09-11 18:20 +0200
        Re: [Outreachy kernel] Re: [PATCH] Staging: ccree: Don't use volatile  for monitor_lock Srishti Sharma <srishtishar@gmail.com> - 2017-09-11 18:40 +0200
  Re: [Outreachy kernel] [PATCH] Staging: ccree: Don't use volatile  for monitor_lock Julia Lawall <julia.lawall@lip6.fr> - 2017-09-11 18:10 +0200
  Re: [PATCH] Staging: ccree: Don't use volatile for monitor_lock Greg KH <gregkh@linuxfoundation.org> - 2017-09-11 18:10 +0200
  Re: [PATCH] Staging: ccree: Don't use volatile for monitor_lock Dan Carpenter <dan.carpenter@oracle.com> - 2017-09-12 11:30 +0200
    Re: [PATCH] Staging: ccree: Don't use volatile for monitor_lock Srishti Sharma <srishtishar@gmail.com> - 2017-09-12 14:10 +0200

csiph-web