Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1730441

Re: [Outreachy kernel] Re: [PATCH] Staging: ccree: Don't use volatile for monitor_lock

Show all headers | View raw

On Mon, Sep 11, 2017 at 9:45 PM, Srishti Sharma <srishtishar@gmail.com> wrote:
> On Mon, Sep 11, 2017 at 9:41 PM, Julia Lawall <julia.lawall@lip6.fr> wrote:
>>
>>
>> On Mon, 11 Sep 2017, Srishti Sharma wrote:
>>
>>> On Mon, Sep 11, 2017 at 9:34 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
>>> > On Mon, Sep 11, 2017 at 09:29:31PM +0530, Srishti Sharma wrote:
>>> >> The use of volatile for the variable monitor_lock is unnecessary.
>>> >>
>>> >> Signed-off-by: Srishti Sharma <srishtishar@gmail.com>
>>> >> ---
>>> >>  drivers/staging/ccree/ssi_request_mgr.c | 2 +-
>>> >>  1 file changed, 1 insertion(+), 1 deletion(-)
>>> >>
>>> >> diff --git a/drivers/staging/ccree/ssi_request_mgr.c b/drivers/staging/ccree/ssi_request_mgr.c
>>> >> index e5c2f92..7d77941 100644
>>> >> --- a/drivers/staging/ccree/ssi_request_mgr.c
>>> >> +++ b/drivers/staging/ccree/ssi_request_mgr.c
>>> >> @@ -49,7 +49,7 @@ struct ssi_request_mgr_handle {
>>> >>       dma_addr_t dummy_comp_buff_dma;
>>> >>       struct cc_hw_desc monitor_desc;
>>> >>
>>> >> -     volatile unsigned long monitor_lock;
>>> >> +     unsigned long monitor_lock;
>>> >
>>> > While volatile is not right, odds are, this is still totally wrong as
>>> > well.  How about using a "real" lock instead?
>>>
>>> I tried to find where is this variable being used in the code, but I
>>> didn't find any usage of it . It might be an important attribute of
>>> this structure definition but, I don't see it's value being set to
>>> anything or being used somewhere .
>>
>> Try removing it and see if the code still compiles.  There is always a
>> danger that a use of something could be constructed using ## in a macro,
>> although given the uses of ## for this driver, it doesn't seem likely
>> here.

It compiles, so I have removed the variable and sent another patch

Thanks,
Srishti

>
> Yes, I'll do that.
>
> Regards,
> Srishti
>>
>> julia

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] Staging: ccree: Don't use volatile for monitor_lock Srishti Sharma <srishtishar@gmail.com> - 2017-09-11 18:00 +0200
  Re: [PATCH] Staging: ccree: Don't use volatile for monitor_lock Srishti Sharma <srishtishar@gmail.com> - 2017-09-11 18:10 +0200
    Re: [Outreachy kernel] Re: [PATCH] Staging: ccree: Don't use volatile  for monitor_lock Sean Paul <seanpaul@chromium.org> - 2017-09-11 18:20 +0200
    Re: [Outreachy kernel] Re: [PATCH] Staging: ccree: Don't use volatile  for monitor_lock Julia Lawall <julia.lawall@lip6.fr> - 2017-09-11 18:20 +0200
      Re: [Outreachy kernel] Re: [PATCH] Staging: ccree: Don't use volatile  for monitor_lock Srishti Sharma <srishtishar@gmail.com> - 2017-09-11 18:20 +0200
        Re: [Outreachy kernel] Re: [PATCH] Staging: ccree: Don't use volatile  for monitor_lock Srishti Sharma <srishtishar@gmail.com> - 2017-09-11 18:40 +0200
  Re: [Outreachy kernel] [PATCH] Staging: ccree: Don't use volatile  for monitor_lock Julia Lawall <julia.lawall@lip6.fr> - 2017-09-11 18:10 +0200
  Re: [PATCH] Staging: ccree: Don't use volatile for monitor_lock Greg KH <gregkh@linuxfoundation.org> - 2017-09-11 18:10 +0200
  Re: [PATCH] Staging: ccree: Don't use volatile for monitor_lock Dan Carpenter <dan.carpenter@oracle.com> - 2017-09-12 11:30 +0200
    Re: [PATCH] Staging: ccree: Don't use volatile for monitor_lock Srishti Sharma <srishtishar@gmail.com> - 2017-09-12 14:10 +0200

csiph-web