Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1726919

Re: [PATCH v3 06/11] perf, tools, stat: Support JSON metrics in perf stat

Show all headers | View raw

On Tue, Sep 05, 2017 at 03:09:19PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Mon, Sep 04, 2017 at 10:37:25AM -0700, Andi Kleen escreveu:
> > On Mon, Sep 04, 2017 at 02:11:28PM -0300, Arnaldo Carvalho de Melo wrote:
> > > Em Thu, Aug 31, 2017 at 12:40:31PM -0700, Andi Kleen escreveu:
> > > > The actual JSON metrics are in a separate pull request.
> > > 
> > > Yeah, I noticed when trying to test it :-\
> > > 
> > > Was this pull req submitted?
> > 
> > Not yet. I was waiting to finish review.
> > 
> > It makes perf crash until you apply the metricgroup patchkit first.
> > 
> > But you can get it here
> > 
> > git://git.kernel.org/pub/scm/linux/kernel/git/ak/linux-misc.git perf/intel-json-metrics-2
> 
> Ok, so I tried installing the Broadwell ones (one of my test machines)
> and got into:

I would suggest to apply all the patches from the patchkit before you test.
Some of the later ones add/fix stuff needed by some of the metrics.

> 
> [root@jouet ~]# perf stat -M Pipeline flops
> bpf: builtin compilation failed: -95, try external compiler
> ERROR: problems with path cpu/uops_executed.c: No such file or directory
> Cannot set up events {uops_retired.retire_slots,inst_retired.any}:W,{inst_retired.any,cycles}:W,{uops_executed.thread,cpu/uops_executed.core,cmask=1/,uops_executed.cycles_ge_1_uop_exec}:W
> 
>  Usage: perf stat [<options>] [<command>]
> 
>     -M, --metrics <metric/metric group list>
>                           monitor specified metrics or metric groups (separated by ,)
> [root@jouet ~]# perf stat -M Pipeline flops
> 
> 
> Wasn't this already fixed?

Yes that was supposed to be fixed with 

commit 77d0871c76bad1093a3d86870fe76dd1ad0ca397
Author: Andi Kleen <ak@linux.intel.com>
Date:   Fri Aug 11 16:26:19 2017 -0700

    perf bpf: Tighten detection of BPF events
    
      perf stat -e cpu/uops_executed.core,cmask=1/


I'll check.

-Andi

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Support standalone metrics and metric groups for perf Andi Kleen <andi@firstfloor.org> - 2017-08-31 21:50 +0200
  [PATCH v3 07/11] perf, tools, list: Add metric groups to perf list Andi Kleen <andi@firstfloor.org> - 2017-08-31 21:50 +0200
  [PATCH v3 11/11] perf, tools, stat: Update walltime_nsecs_stats in interval mode Andi Kleen <andi@firstfloor.org> - 2017-08-31 21:50 +0200
  [PATCH v3 06/11] perf, tools, stat: Support JSON metrics in perf stat Andi Kleen <andi@firstfloor.org> - 2017-08-31 21:50 +0200
    Re: [PATCH v3 06/11] perf, tools, stat: Support JSON metrics in perf  stat Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-09-04 19:20 +0200
      Re: [PATCH v3 06/11] perf, tools, stat: Support JSON metrics in perf  stat Andi Kleen <andi@firstfloor.org> - 2017-09-04 19:40 +0200
        Re: [PATCH v3 06/11] perf, tools, stat: Support JSON metrics in perf  stat Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-09-05 20:10 +0200
          Re: [PATCH v3 06/11] perf, tools, stat: Support JSON metrics in perf  stat Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-09-05 20:20 +0200
            Re: [PATCH v3 06/11] perf, tools, stat: Support JSON metrics in perf  stat Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-09-05 20:40 +0200
          Re: [PATCH v3 06/11] perf, tools, stat: Support JSON metrics in perf  stat Andi Kleen <ak@linux.intel.com> - 2017-09-05 20:30 +0200
            Re: [PATCH v3 06/11] perf, tools, stat: Support JSON metrics in perf  stat Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-09-05 21:00 +0200
              Re: [PATCH v3 06/11] perf, tools, stat: Support JSON metrics in perf  stat Andi Kleen <andi@firstfloor.org> - 2017-09-05 22:00 +0200
                Re: [PATCH v3 06/11] perf, tools, stat: Support JSON metrics in perf  stat Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-09-05 22:10 +0200
                Re: [PATCH v3 06/11] perf, tools, stat: Support JSON metrics in perf  stat Andi Kleen <ak@linux.intel.com> - 2017-09-05 22:40 +0200
                Re: [PATCH v3 06/11] perf, tools, stat: Support JSON metrics in perf  stat Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-09-08 20:20 +0200
                Re: [PATCH v3 06/11] perf, tools, stat: Support JSON metrics in perf  stat Andi Kleen <ak@linux.intel.com> - 2017-09-08 21:10 +0200
  [PATCH v3 04/11] perf, tools: Print generic metric header even for failed expressions Andi Kleen <andi@firstfloor.org> - 2017-08-31 21:50 +0200
  [PATCH v3 10/11] perf, tools, stat: Hide internal duration_time counter Andi Kleen <andi@firstfloor.org> - 2017-08-31 21:50 +0200
  [PATCH v3 09/11] perf, tools, stat: Support duration_time for metrics Andi Kleen <andi@firstfloor.org> - 2017-08-31 21:50 +0200
  [PATCH v3 01/11] perf, tools: Support weak groups Andi Kleen <andi@firstfloor.org> - 2017-08-31 21:50 +0200
    Re: [PATCH v3 01/11] perf, tools: Support weak groups Jiri Olsa <jolsa@redhat.com> - 2017-09-01 19:00 +0200
      Re: [PATCH v3 01/11] perf, tools: Support weak groups Jiri Olsa <jolsa@redhat.com> - 2017-09-01 19:10 +0200
        Re: [PATCH v3 01/11] perf, tools: Support weak groups Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-09-04 19:00 +0200
  [PATCH v3 08/11] perf, tools, stat: Don't use ctx for saved values lookup Andi Kleen <andi@firstfloor.org> - 2017-08-31 21:50 +0200
  Re: Support standalone metrics and metric groups for perf Jiri Olsa <jolsa@redhat.com> - 2017-09-01 19:30 +0200
    Re: Support standalone metrics and metric groups for perf Jiri Olsa <jolsa@redhat.com> - 2017-09-01 19:40 +0200
    Re: Support standalone metrics and metric groups for perf Andi Kleen <andi@firstfloor.org> - 2017-09-01 19:50 +0200
      Re: Support standalone metrics and metric groups for perf Jiri Olsa <jolsa@redhat.com> - 2017-09-01 20:00 +0200

csiph-web