Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1724534
| From | Andi Kleen <andi@firstfloor.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH v3 09/11] perf, tools, stat: Support duration_time for metrics |
| Date | 2017-08-31 21:50 +0200 |
| Message-ID | <ukDDs-1ub-35@gated-at.bofh.it> (permalink) |
| References | <ukDDr-1ub-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
From: Andi Kleen <ak@linux.intel.com>
Some of the metrics formulas (like GFLOPs) need to know how long
the measurement period is. Support an internal event called duration_time, which
reports time in second. It maps to the dummy event, but is
special cased for statistics to report the walltime duration.
So far it is not printed, but only used internally for metrics.
Signed-off-by: Andi Kleen <ak@linux.intel.com>
---
tools/perf/util/parse-events.l | 1 +
tools/perf/util/stat-shadow.c | 17 +++++++++++++----
2 files changed, 14 insertions(+), 4 deletions(-)
diff --git a/tools/perf/util/parse-events.l b/tools/perf/util/parse-events.l
index fdb5bb52f01f..ea2426daf7e8 100644
--- a/tools/perf/util/parse-events.l
+++ b/tools/perf/util/parse-events.l
@@ -288,6 +288,7 @@ cpu-migrations|migrations { return sym(yyscanner, PERF_TYPE_SOFTWARE, PERF_COU
alignment-faults { return sym(yyscanner, PERF_TYPE_SOFTWARE, PERF_COUNT_SW_ALIGNMENT_FAULTS); }
emulation-faults { return sym(yyscanner, PERF_TYPE_SOFTWARE, PERF_COUNT_SW_EMULATION_FAULTS); }
dummy { return sym(yyscanner, PERF_TYPE_SOFTWARE, PERF_COUNT_SW_DUMMY); }
+duration_time { return sym(yyscanner, PERF_TYPE_SOFTWARE, PERF_COUNT_SW_DUMMY); }
bpf-output { return sym(yyscanner, PERF_TYPE_SOFTWARE, PERF_COUNT_SW_BPF_OUTPUT); }
/*
diff --git a/tools/perf/util/stat-shadow.c b/tools/perf/util/stat-shadow.c
index 664f49a9b012..a2c12d1ef32a 100644
--- a/tools/perf/util/stat-shadow.c
+++ b/tools/perf/util/stat-shadow.c
@@ -641,11 +641,20 @@ static void generic_metric(const char *metric_expr,
expr__add_id(&pctx, name, avg);
for (i = 0; metric_events[i]; i++) {
struct saved_value *v;
+ struct stats *stats;
+ double scale;
- v = saved_value_lookup(metric_events[i], cpu, false);
- if (!v)
- break;
- expr__add_id(&pctx, metric_events[i]->name, avg_stats(&v->stats));
+ if (!strcmp(metric_events[i]->name, "duration_time")) {
+ stats = &walltime_nsecs_stats;
+ scale = 1e-9;
+ } else {
+ v = saved_value_lookup(metric_events[i], cpu, false);
+ if (!v)
+ break;
+ stats = &v->stats;
+ scale = 1.0;
+ }
+ expr__add_id(&pctx, metric_events[i]->name, avg_stats(stats)*scale);
}
if (!metric_events[i]) {
const char *p = metric_expr;
--
2.9.5
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Support standalone metrics and metric groups for perf Andi Kleen <andi@firstfloor.org> - 2017-08-31 21:50 +0200
[PATCH v3 07/11] perf, tools, list: Add metric groups to perf list Andi Kleen <andi@firstfloor.org> - 2017-08-31 21:50 +0200
[PATCH v3 11/11] perf, tools, stat: Update walltime_nsecs_stats in interval mode Andi Kleen <andi@firstfloor.org> - 2017-08-31 21:50 +0200
[PATCH v3 06/11] perf, tools, stat: Support JSON metrics in perf stat Andi Kleen <andi@firstfloor.org> - 2017-08-31 21:50 +0200
Re: [PATCH v3 06/11] perf, tools, stat: Support JSON metrics in perf stat Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-09-04 19:20 +0200
Re: [PATCH v3 06/11] perf, tools, stat: Support JSON metrics in perf stat Andi Kleen <andi@firstfloor.org> - 2017-09-04 19:40 +0200
Re: [PATCH v3 06/11] perf, tools, stat: Support JSON metrics in perf stat Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-09-05 20:10 +0200
Re: [PATCH v3 06/11] perf, tools, stat: Support JSON metrics in perf stat Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-09-05 20:20 +0200
Re: [PATCH v3 06/11] perf, tools, stat: Support JSON metrics in perf stat Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-09-05 20:40 +0200
Re: [PATCH v3 06/11] perf, tools, stat: Support JSON metrics in perf stat Andi Kleen <ak@linux.intel.com> - 2017-09-05 20:30 +0200
Re: [PATCH v3 06/11] perf, tools, stat: Support JSON metrics in perf stat Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-09-05 21:00 +0200
Re: [PATCH v3 06/11] perf, tools, stat: Support JSON metrics in perf stat Andi Kleen <andi@firstfloor.org> - 2017-09-05 22:00 +0200
Re: [PATCH v3 06/11] perf, tools, stat: Support JSON metrics in perf stat Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-09-05 22:10 +0200
Re: [PATCH v3 06/11] perf, tools, stat: Support JSON metrics in perf stat Andi Kleen <ak@linux.intel.com> - 2017-09-05 22:40 +0200
Re: [PATCH v3 06/11] perf, tools, stat: Support JSON metrics in perf stat Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-09-08 20:20 +0200
Re: [PATCH v3 06/11] perf, tools, stat: Support JSON metrics in perf stat Andi Kleen <ak@linux.intel.com> - 2017-09-08 21:10 +0200
[PATCH v3 04/11] perf, tools: Print generic metric header even for failed expressions Andi Kleen <andi@firstfloor.org> - 2017-08-31 21:50 +0200
[PATCH v3 10/11] perf, tools, stat: Hide internal duration_time counter Andi Kleen <andi@firstfloor.org> - 2017-08-31 21:50 +0200
[PATCH v3 09/11] perf, tools, stat: Support duration_time for metrics Andi Kleen <andi@firstfloor.org> - 2017-08-31 21:50 +0200
[PATCH v3 01/11] perf, tools: Support weak groups Andi Kleen <andi@firstfloor.org> - 2017-08-31 21:50 +0200
Re: [PATCH v3 01/11] perf, tools: Support weak groups Jiri Olsa <jolsa@redhat.com> - 2017-09-01 19:00 +0200
Re: [PATCH v3 01/11] perf, tools: Support weak groups Jiri Olsa <jolsa@redhat.com> - 2017-09-01 19:10 +0200
Re: [PATCH v3 01/11] perf, tools: Support weak groups Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-09-04 19:00 +0200
[PATCH v3 08/11] perf, tools, stat: Don't use ctx for saved values lookup Andi Kleen <andi@firstfloor.org> - 2017-08-31 21:50 +0200
Re: Support standalone metrics and metric groups for perf Jiri Olsa <jolsa@redhat.com> - 2017-09-01 19:30 +0200
Re: Support standalone metrics and metric groups for perf Jiri Olsa <jolsa@redhat.com> - 2017-09-01 19:40 +0200
Re: Support standalone metrics and metric groups for perf Andi Kleen <andi@firstfloor.org> - 2017-09-01 19:50 +0200
Re: Support standalone metrics and metric groups for perf Jiri Olsa <jolsa@redhat.com> - 2017-09-01 20:00 +0200
csiph-web