Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1725231
| From | Jiri Olsa <jolsa@redhat.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v3 01/11] perf, tools: Support weak groups |
| Date | 2017-09-01 19:00 +0200 |
| Message-ID | <ukXsu-7Iv-15@gated-at.bofh.it> (permalink) |
| References | <ukDDr-1ub-3@gated-at.bofh.it> <ukDDt-1ub-37@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Thu, Aug 31, 2017 at 12:40:26PM -0700, Andi Kleen wrote:
> From: Andi Kleen <ak@linux.intel.com>
>
> Setting up groups can be complicated due to the
> complicated scheduling restrictions of different PMUs.
> User tools usually don't understand all these restrictions.
> Still in many cases it is useful to set up groups and
> they work most of the time. However if the group
> is set up wrong some members will not reported any values
> because they never get scheduled.
>
> Add a concept of a 'weak group': try to set up a group,
> but if it's not schedulable fallback to not using
> a group. That gives us the best of both worlds:
> groups if they work, but still a usable fallback if they don't.
>
> In theory it would be possible to have more complex fallback
> strategies (e.g. try to split the group in half), but
> the simple fallback of not using a group seems to work for now.
>
> So far the weak group is only implemented for perf stat,
> not for record.
>
> Here's an unschedulable group (on IvyBridge with SMT on)
>
> % perf stat -e '{branches,branch-misses,l1d.replacement,l2_lines_in.all,l2_rqsts.all_code_rd}' -a sleep 1
>
> 73,806,067 branches
> 4,848,144 branch-misses # 6.57% of all branches
> 14,754,458 l1d.replacement
> 24,905,558 l2_lines_in.all
> <not supported> l2_rqsts.all_code_rd <------- will never report anything
>
> With the weak group:
>
> % perf stat -e '{branches,branch-misses,l1d.replacement,l2_lines_in.all,l2_rqsts.all_code_rd}:W' -a sleep 1
>
> 125,366,055 branches (80.02%)
> 9,208,402 branch-misses # 7.35% of all branches (80.01%)
> 24,560,249 l1d.replacement (80.00%)
> 43,174,971 l2_lines_in.all (80.05%)
> 31,891,457 l2_rqsts.all_code_rd (79.92%)
>
> The extra event scheduled with some extra multiplexing
>
> v2: Move fallback code to separate function.
> Add comment on for_each_group_member
> Adjust to new perf_evsel__close interface
> v3:
> Fix debug print out.
> Signed-off-by: Andi Kleen <ak@linux.intel.com>
Acked-by: Jiri Olsa <jolsa@kernel.org>
thanks,
jirka
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Support standalone metrics and metric groups for perf Andi Kleen <andi@firstfloor.org> - 2017-08-31 21:50 +0200
[PATCH v3 07/11] perf, tools, list: Add metric groups to perf list Andi Kleen <andi@firstfloor.org> - 2017-08-31 21:50 +0200
[PATCH v3 11/11] perf, tools, stat: Update walltime_nsecs_stats in interval mode Andi Kleen <andi@firstfloor.org> - 2017-08-31 21:50 +0200
[PATCH v3 06/11] perf, tools, stat: Support JSON metrics in perf stat Andi Kleen <andi@firstfloor.org> - 2017-08-31 21:50 +0200
Re: [PATCH v3 06/11] perf, tools, stat: Support JSON metrics in perf stat Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-09-04 19:20 +0200
Re: [PATCH v3 06/11] perf, tools, stat: Support JSON metrics in perf stat Andi Kleen <andi@firstfloor.org> - 2017-09-04 19:40 +0200
Re: [PATCH v3 06/11] perf, tools, stat: Support JSON metrics in perf stat Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-09-05 20:10 +0200
Re: [PATCH v3 06/11] perf, tools, stat: Support JSON metrics in perf stat Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-09-05 20:20 +0200
Re: [PATCH v3 06/11] perf, tools, stat: Support JSON metrics in perf stat Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-09-05 20:40 +0200
Re: [PATCH v3 06/11] perf, tools, stat: Support JSON metrics in perf stat Andi Kleen <ak@linux.intel.com> - 2017-09-05 20:30 +0200
Re: [PATCH v3 06/11] perf, tools, stat: Support JSON metrics in perf stat Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-09-05 21:00 +0200
Re: [PATCH v3 06/11] perf, tools, stat: Support JSON metrics in perf stat Andi Kleen <andi@firstfloor.org> - 2017-09-05 22:00 +0200
Re: [PATCH v3 06/11] perf, tools, stat: Support JSON metrics in perf stat Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-09-05 22:10 +0200
Re: [PATCH v3 06/11] perf, tools, stat: Support JSON metrics in perf stat Andi Kleen <ak@linux.intel.com> - 2017-09-05 22:40 +0200
Re: [PATCH v3 06/11] perf, tools, stat: Support JSON metrics in perf stat Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-09-08 20:20 +0200
Re: [PATCH v3 06/11] perf, tools, stat: Support JSON metrics in perf stat Andi Kleen <ak@linux.intel.com> - 2017-09-08 21:10 +0200
[PATCH v3 04/11] perf, tools: Print generic metric header even for failed expressions Andi Kleen <andi@firstfloor.org> - 2017-08-31 21:50 +0200
[PATCH v3 10/11] perf, tools, stat: Hide internal duration_time counter Andi Kleen <andi@firstfloor.org> - 2017-08-31 21:50 +0200
[PATCH v3 09/11] perf, tools, stat: Support duration_time for metrics Andi Kleen <andi@firstfloor.org> - 2017-08-31 21:50 +0200
[PATCH v3 01/11] perf, tools: Support weak groups Andi Kleen <andi@firstfloor.org> - 2017-08-31 21:50 +0200
Re: [PATCH v3 01/11] perf, tools: Support weak groups Jiri Olsa <jolsa@redhat.com> - 2017-09-01 19:00 +0200
Re: [PATCH v3 01/11] perf, tools: Support weak groups Jiri Olsa <jolsa@redhat.com> - 2017-09-01 19:10 +0200
Re: [PATCH v3 01/11] perf, tools: Support weak groups Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-09-04 19:00 +0200
[PATCH v3 08/11] perf, tools, stat: Don't use ctx for saved values lookup Andi Kleen <andi@firstfloor.org> - 2017-08-31 21:50 +0200
Re: Support standalone metrics and metric groups for perf Jiri Olsa <jolsa@redhat.com> - 2017-09-01 19:30 +0200
Re: Support standalone metrics and metric groups for perf Jiri Olsa <jolsa@redhat.com> - 2017-09-01 19:40 +0200
Re: Support standalone metrics and metric groups for perf Andi Kleen <andi@firstfloor.org> - 2017-09-01 19:50 +0200
Re: Support standalone metrics and metric groups for perf Jiri Olsa <jolsa@redhat.com> - 2017-09-01 20:00 +0200
csiph-web