[PATCH 5/7] [media] ov9640: Improve a size determination in ov9640_probe()

Path	csiph.com!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod
From	SF Markus Elfring <elfring@users.sourceforge.net>
Newsgroups	linux.kernel
Subject	[PATCH 5/7] [media] ov9640: Improve a size determination in ov9640_probe()
Date	Sat, 02 Sep 2017 18:00:01 +0200
Message-ID	<uliZX-4Mu-3@gated-at.bofh.it> (permalink)
References	<uliQh-4Hk-5@gated-at.bofh.it>
X-Original-To	linux-media@vger.kernel.org, Bhumika Goyal <bhumirks@gmail.com>, Frank Schäfer <fschaefer.oss@googlemail.com>, Guennadi Liakhovetski <g.liakhovetski@gmx.de>, Hans Verkuil <hans.verkuil@cisco.com>, Janusz Krzysztofik <jmkrzyszt@gmail.com>, Mauro Carvalho Chehab <mchehab@kernel.org>, Sakari Ailus <sakari.ailus@linux.intel.com>
User-Agent	Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0
MIME-Version	1.0
Content-Type	text/plain; charset=utf-8
Content-Language	en-GB
Content-Transfer-Encoding	8bit
X-Provags-ID	V03:K0:CjWhcSUDYCACuxLIMWd+t/67pKcf59LGfXABIdATHYewxMgbTHD Z4h5Nm1yd/zU3GMDkslakgdg67xAUgfWu1KIAtQzvq8IahtJltdWNsNbEQe2H1v2JU03HTP VYE2UkhI6uzFoNEuIJvNPJmvk4Q8LISkFKs59UjZRsbCUicEsi6a3oE30pz+YbOIPqHhNxr eLvKMEOeaP8USVeRKly+w==
X-Ui-Out-Filterresults	notjunk:1;V01:K0:Ll2KcXUe2CY=:ZUR7qD4PQSQOC200LCGM13 SW12MnAkG8+i1WC8ck+ctluW1SEn4n49vcqlHBSJJ+YeVYg1DOa4IGImaXr+37g2Y9Ij2iFN1 mphhcQKZ8p9CQdjqgh7UwYsCLnNMB7T9NoPkdbbcKg2q1/dNkf+0Dbpxl66YfKB96hLTt2UhG PiDafVOaP1ag1nd+7BEnToXGyK22jbk3K7VLqakVJtDRKkDkqm4adIT8nMqoFmvYM+/K9sMbJ y1W2HKtuSMUhAaVq3et6c3FxLctnmQfBbZWsUzKq3EH4s/bpGS62C0l9eRr0VkjZoCQlSj0oa cdhS+5LklgGRvsF7YewzfnyCizvV+jOBTlUbfRHmytxlmHGIeUI5P3FASf7IaPDcBgeqJadQ4 SU/pYwPMaaFVsrMVHnxLDmnVsq8VslLteWuOCeaCHXcGeImAalTx8HXNIqkXuPt6FTlaDw+WU DtShfwu8VYSgqgb+sy1MpRpIikFQ6m9D59imv9A5EDqOE8WJW7+KkHkXchcfJN9+cvI74n2d0 HnB0DLQU6Tf8JgmZgzoTkXzntfJAbgYyBK3TQvueG80HoAlKoKZRb2HP9FHq6i04GPxdUkLVO 2QanAZeVIY5Om8zX83YDZay5kT/j5Ai+Wr8XtzDG1gV39tby0eNp5xoTC571iT76OlcRkKi6A urorpB80cNWo6D4ZGrjo46x3azLzLGGXBBBpR2splQSQ2OtVBYe1MBWnBJ60vvMRGQUY1rwew Vv1nMnHCM8mZ5xXopEvphE3LcTMkux7pmaX4hiRRjkLhgLIpIt6sYFAAtTfGIzYYdaZwlfUky qHVsjdDKE1+61/FcJXxGHKjEw9BUFwYPsqIqJ0/LBzaMB/4vo8=
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	27
Organization	linux.* mail to news gateway
X-Original-Cc	LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
X-Original-Date	Sat, 2 Sep 2017 17:52:05 +0200
X-Original-Message-ID	<5d342b6f-8283-c1ce-5469-fefeffcc05d4@users.sourceforge.net>
X-Original-References	<c9f2ba21-c742-e1e8-26d9-a56c51c56d65@users.sourceforge.net>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1725520

Show key headers only | View raw

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sat, 2 Sep 2017 16:37:03 +0200

Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/media/i2c/soc_camera/ov9640.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/i2c/soc_camera/ov9640.c b/drivers/media/i2c/soc_camera/ov9640.c
index 0f02f022f3e9..67578f194928 100644
--- a/drivers/media/i2c/soc_camera/ov9640.c
+++ b/drivers/media/i2c/soc_camera/ov9640.c
@@ -675,5 +675,5 @@ static int ov9640_probe(struct i2c_client *client,
 		return -EINVAL;
 	}
 
-	priv = devm_kzalloc(&client->dev, sizeof(struct ov9640_priv), GFP_KERNEL);
+	priv = devm_kzalloc(&client->dev, sizeof(*priv), GFP_KERNEL);
 	if (!priv)
-- 
2.14.1

Thread

[PATCH 0/7] [media] OmniVision: Adjustments for four function  implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-02 17:50 +0200
  [PATCH 5/7] [media] ov9640: Improve a size determination in  ov9640_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-02 18:00 +0200
  [PATCH 3/7] [media] ov6650: Delete an error message for a failed  memory allocation in ov6650_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-02 18:00 +0200
  [PATCH 6/7] [media] ov9740: Delete an error message for a failed  memory allocation in ov9740_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-02 18:00 +0200
  [PATCH 4/7] [media] ov9640: Delete an error message for a failed  memory allocation in ov9640_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-02 18:00 +0200
  [PATCH 7/7] [media] ov9740: Improve a size determination in  ov9740_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-02 18:00 +0200

csiph-web