[PATCH 7/7] [media] ov9740: Improve a size determination in ov9740_probe()

From	SF Markus Elfring <elfring@users.sourceforge.net>
Newsgroups	linux.kernel
Subject	[PATCH 7/7] [media] ov9740: Improve a size determination in ov9740_probe()
Date	2017-09-02 18:00 +0200
Message-ID	<uliZY-4Mu-27@gated-at.bofh.it> (permalink)
References	<uliQh-4Hk-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sat, 2 Sep 2017 16:46:03 +0200

Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/media/i2c/soc_camera/ov9740.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/i2c/soc_camera/ov9740.c b/drivers/media/i2c/soc_camera/ov9740.c
index f44f5da795f9..755de2289c39 100644
--- a/drivers/media/i2c/soc_camera/ov9740.c
+++ b/drivers/media/i2c/soc_camera/ov9740.c
@@ -935,5 +935,5 @@ static int ov9740_probe(struct i2c_client *client,
 		return -EINVAL;
 	}
 
-	priv = devm_kzalloc(&client->dev, sizeof(struct ov9740_priv), GFP_KERNEL);
+	priv = devm_kzalloc(&client->dev, sizeof(*priv), GFP_KERNEL);
 	if (!priv)
-- 
2.14.1

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/7] [media] OmniVision: Adjustments for four function  implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-02 17:50 +0200
  [PATCH 5/7] [media] ov9640: Improve a size determination in  ov9640_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-02 18:00 +0200
  [PATCH 3/7] [media] ov6650: Delete an error message for a failed  memory allocation in ov6650_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-02 18:00 +0200
  [PATCH 6/7] [media] ov9740: Delete an error message for a failed  memory allocation in ov9740_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-02 18:00 +0200
  [PATCH 4/7] [media] ov9640: Delete an error message for a failed  memory allocation in ov9640_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-02 18:00 +0200
  [PATCH 7/7] [media] ov9740: Improve a size determination in  ov9740_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-02 18:00 +0200

csiph-web